revise error messages with regards to DerivationIndex #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
changed the title
The current errors were saying black and white at the same time. Understanding what was a valid a value for derivation index and what was not was unclear.
KtorZ
force-pushed
the
KtorZ/ADP-509/error-revisions
branch
from
96c62fb to
bb6528d
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 26, 2020
2269: revise error messages with regards to DerivationIndex r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> ADP-509 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 0d1f207 📍 **revise error messages and error code for DerivationIndex** The current errors were saying black and white at the same time. Understanding what was a valid a value for derivation index and what was not was unclear. - 96c62fb 📍 **remove 409 Conflict from possible errors of the new signature endpoint.** # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2270: Drop `PoolMetadataFetchAttempts` in `removePoolMetadata` r=hasufell a=hasufell When removing pool metadata, there's no point in keeping the last fetch attempts. In fact, this might delay re-syncing further. Co-authored-by: KtorZ <[email protected]> Co-authored-by: Julian Ospald <[email protected]>
paweljakubas
approved these changes
Oct 26, 2020
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-509
Overview
0d1f207
📍 revise error messages and error code for DerivationIndex
The current errors were saying black and white at the same time. Understanding what was a valid a value for derivation index and what was not was unclear.
96c62fb
📍 remove 409 Conflict from possible errors of the new signature endpoint.
Comments