Add N={20,40,80} wallet restore benchmarks #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To more easily see if the restoration times increase linearly with N.
KtorZ
reviewed
Oct 21, 2020
| @@ -287,6 +287,9 @@ cardanoRestoreBench tr c socketFile = do | |||
| -- to-100% time. | |||
| benchRestoreMultipleWallets 1 (unsafeMkPercentage 0.1) | |||
| , benchRestoreMultipleWallets 10 (unsafeMkPercentage 0.01) | |||
| , benchRestoreMultipleWallets 20 (unsafeMkPercentage 0.01) | |||
| , benchRestoreMultipleWallets 40 (unsafeMkPercentage 0.01) | |||
| , benchRestoreMultipleWallets 80 (unsafeMkPercentage 0.01) | |||
| , benchRestoreMultipleWallets 100 (unsafeMkPercentage 0.01) | |||
There was a problem hiding this comment.
What about removing 100, so we keep a nice x2 factor between each bench.
There was a problem hiding this comment.
Or make it 160? 😸 (Perhaps that would be too long.)
There was a problem hiding this comment.
By keeping 100 we can still reason about 1 vs 10 vs 100.
|
bors r+ |
|
👎 Rejected by too few approved reviews |
paweljakubas
approved these changes
Oct 23, 2020
|
(ty!) |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 23, 2020
2260: Add N={20,40,80} wallet restore benchmarks r=Anviking a=Anviking
# Issue Number
ADP-469
# Overview
- Add N={20,40,80} wallet restore benchmarks, to have more data points to see if it is linear or not.
# Comments
Buildkite nightly build: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/685
<!-- Additional comments or screenshots to attach if any -->
<!--
Don't forget to:
✓ Self-review your changes to make sure nothing unexpected slipped through
✓ Assign yourself to the PR
✓ Assign one or several reviewer(s)
✓ Once created, link this PR to its corresponding ticket
✓ Assign the PR to a corresponding milestone
✓ Acknowledge any changes required to the Wiki
-->
Co-authored-by: Johannes Lund <[email protected]>
|
Plot + regression with some recent data from CI: |
|
Timed out. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 23, 2020
2260: Add N={20,40,80} wallet restore benchmarks r=Anviking a=Anviking
# Issue Number
ADP-469
# Overview
- Add N={20,40,80} wallet restore benchmarks, to have more data points to see if it is linear or not.
# Comments
Buildkite nightly build: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/685
<!-- Additional comments or screenshots to attach if any -->
<!--
Don't forget to:
✓ Self-review your changes to make sure nothing unexpected slipped through
✓ Assign yourself to the PR
✓ Assign one or several reviewer(s)
✓ Once created, link this PR to its corresponding ticket
✓ Assign the PR to a corresponding milestone
✓ Acknowledge any changes required to the Wiki
-->
Co-authored-by: Johannes Lund <[email protected]>
|
Timed out. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-469
Overview
Comments
Buildkite nightly build: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/685