-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADP-494 - Add POST endpoint for script address #2253
Changes from all commits
a86e8c7
eee6f17
5c9ad40
74fe268
9319cb1
60066ec
03524d0
c456474
82f083a
5322b95
5bb1383
41a1e1c
6d95b74
cd79af0
8c63aa9
6831d1e
c6ee9ba
043b1f0
5f0be33
b51857e
d8b140a
ce151c6
4f14272
18b825a
c50b1c5
cf40f51
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -317,6 +317,7 @@ addressClient = | |
let | ||
_listAddresses | ||
:<|> _inspectAddress | ||
:<|> _postScriptAddress | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. small note: the endpoint suggest that we can post any address here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, I "coined this name" due to the fact that ANY address could be constructed: base, reward account, enterprise, each with any credential. Of course there is also pointer address which was omitted in this PR (but could be added in the forthcoming) |
||
= client (Proxy @("v2" :> Addresses Aeson.Value)) | ||
in | ||
AddressClient | ||
|
@@ -336,6 +337,7 @@ byronAddressClient | |
byronAddressClient = | ||
let | ||
_ :<|> _inspectAddress | ||
:<|> _postScriptAddress | ||
= client (Proxy @("v2" :> Addresses Aeson.Value)) | ||
|
||
_postRandomAddress | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking but why golden? Afaik, golden are unit tests with output in separate file which is not the case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golden because I have generated golden data in cardano-address for all examples, and check if all json/handling/.. machinery comes to the same results