Use JSON "detailed schema" for API TxMetadata #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
ADDING FEATURE
rvl
force-pushed
the
rvl/adp-307/json-metadata
branch
from
560e6d9 to
8a54eed
Compare
KtorZ
approved these changes
Sep 21, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-307 / #2073
Overview
Changes the API to use the "detailed" JSON schema for transaction metadata.
With this scheme, API users will always see exactly the same JSON in the transaction history and cardano explorer as what they submitted with the transaction.
Comments
We may wish to support both formats in the API.
This PR is based on the branch of #2142.