More sanity byron random-specific benchmarks post restoration + JSON artifacts #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w stdout For consistency and also, better log outputs.
KtorZ
added
the
IMPROVEMENT
KtorZ
force-pushed
the
KtorZ/benchmarks
branch
from
257e930 to
d219f16
Compare
KtorZ
changed the title
Anviking
reviewed
Sep 8, 2020
| @@ -94,6 +99,42 @@ import System.Random | |||
| import qualified Data.Map as Map | |||
| import qualified Data.Set as Set | |||
|
|
|||
| class RndStateLike s where | |||
There was a problem hiding this comment.
👌 (makes me wonder slightly again if records hadn't been nicer)
| , importOneAddressTime :: Time | ||
| , importManyAddressesTime :: Time | ||
| , estimateFeesTime :: Time | ||
| , utxoStatistics :: s |
There was a problem hiding this comment.
I don't see: why do you need to parametrise over s?
There was a problem hiding this comment.
Because I didn't want to define a Buildable instance for ApiUtxoStatistics.
Anviking
approved these changes
Sep 8, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#2032
Overview
71f646d
📍 more sanity benchmarks post-restoration
771e590
📍 revise benchmark logging to use structured logger instead of plain raw stdout For consistency and also, better log outputs.
2b439b7
📍 export benchmark results in structured JSON files for easier post-processing
257e930
📍 add 'importManyAddresses' to the benchmarks for comparison with single address import
Comments
Now also export JSON files as:
{ "listAddressesTime": "2.037 s", "restoreTime": "964.3 s", "benchName": "50-percent-rnd", "readWalletTime": "938.2 ms", "utxoStatistics": { "distribution": { "10000000000000000": 0, "100000000000000": 4, "1000000000000": 1998, "10000000000": 5971, "100000000": 1130, "1000000": 805, "10000": 203, "100": 515, "1000000000": 3217, "100000000000": 9121, "10": 75, "45000000000000000": 0, "1000": 43, "10000000000000": 51, "1000000000000000": 5, "100000": 1661, "10000000": 710 }, "scale": "log10", "total": { "quantity": 5210508362190411, "unit": "lovelace" } }, "importManyAddressesTime": "3.901 s", "importOneAddressTime": "1.706 s", "estimateFeesTime": "2.740 s" }