Add test case for importing invalid addresses for Byron #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 2, 2020
2101: Swap order of waitForProcess and hGetContents to avoid blocking on windows r=Anviking a=Anviking # Issue Number #2083 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Swapping order of operations seems to fix problem that only arises on windows, and with tx >=5 outputs - [x] Fixes `WALLETS_UTXO_02` # Comments - [ ] I am re-running _all_ windows tests locally to be more sure <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2105: Add test case for importing invalid addresses for Byron r=hasufell a=hasufell #2011 Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Julian Ospald <[email protected]>
hasufell
force-pushed
the
hasufell/2011/add-testcase
branch
from
0a34d05 to
bcb1e95
Compare
Canceled |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 2, 2020
2101: Swap order of waitForProcess and hGetContents to avoid blocking on windows r=Anviking a=Anviking # Issue Number #2083 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Swapping order of operations seems to fix problem that only arises on windows, and with tx >=5 outputs - [x] Fixes `WALLETS_UTXO_02` # Comments - [ ] I am re-running _all_ windows tests locally to be more sure <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2105: Add test case for importing invalid addresses for Byron r=hasufell a=hasufell #2011 Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Julian Ospald <[email protected]>
Build failed (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 2, 2020
2105: Add test case for importing invalid addresses for Byron r=hasufell a=hasufell #2011 Co-authored-by: Julian Ospald <[email protected]>
Build failed |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2011