Fix stack build on windows #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
RESOLVING ISSUE
Anviking
approved these changes
Aug 31, 2020
|
(It worked! Thanks for this!) |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 31, 2020
2079: Get TxMetadata from blocks on chain r=rvl a=rvl ### Issue Number ADP-307 / #2077 ### Overview - Initial types, etc. ### Comments - I don't have any serialized block data to make golden tests. But the testing can be done with integration tests. 2088: Bump cardano-base so that shelley-spec-ledger-test compiles r=rvl a=rvl ### Issue Number Found during #2077. ### Overview If you are keen enough to build the test suites of all our dependencies, you would have found `shelley-spec-ledger-test` failing to compile, because it needs a later revision of `cardano-base`. This will fix it. 2092: Fix stack build on windows r=rvl a=rvl ### Issue Number None ### Overview On windows, the stack build would fail with some missing dependencies. There is some stack issue with GHC boot packages. The recommended course of action is to add them as `extra-deps` in `stack.yaml`. This fixes the build. ### Comments Since the libsodium VRF was added, there is now an extra step to get stack builds working on windows. I have updated our [iohk-setup.ps1](https://github.com/input-output-hk/adrestia/wiki/scripts/iohk-setup.ps1) script to install libsodium and configure stack to use it. Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: IOHK <[email protected]>
Build failed (retrying...) |
|
Reinstalled virtualbox on my new machine and followed the steps in the script above. Everything went just fine, well done! Q: The script is a bit in a hidden location at the moment, shall we consider having it cardano-wallet/scripts ? |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
None
Overview
On windows, the stack build would fail with some missing dependencies. There is some stack issue with GHC boot packages. The recommended course of action is to add them as
extra-depsinstack.yaml. This fixes the build.Comments
Since the libsodium VRF was added, there is now an extra step to get stack builds working on windows. I have updated our iohk-setup.ps1 script to install libsodium and configure stack to use it.