Add tx metadata to sqlite database #2091
Conversation
rvl
added
the
ADDING FEATURE
KtorZ
force-pushed
the
rvl/2077/tx-metadata
branch
from
9660fd1 to
c003df8
Compare
rvl
force-pushed
the
rvl/2072/sqlite-tx-metadata
branch
from
ba83ded to
84fefa6
Compare
rvl
force-pushed
the
rvl/2077/tx-metadata
branch
from
b9d1b1a to
d7ca998
Compare
rvl
force-pushed
the
rvl/2072/sqlite-tx-metadata
branch
from
84fefa6 to
d416430
Compare
rvl
force-pushed
the
rvl/2072/sqlite-tx-metadata
branch
from
d416430 to
8c98ca5
Compare
| @@ -128,13 +129,13 @@ import Data.Either | |||
| import Data.Generics.Internal.VL.Lens | |||
| ( (^.) ) | |||
| import Data.List | |||
| ( nub, sortOn, unzip3 ) | |||
| ( nub, sortOn, unzip4 ) | |||
There was a problem hiding this comment.
I like how it started with just unzip2 and gradually increased. We still have 3 left, after which we have to stop further development :)
| dbChunked repsertMany | ||
| [ (TxInKey txInputTxId txInputSourceTxId txInputSourceIndex, i) | ||
| | i@TxIn{..} <- txins ] | ||
| dbChunked repsertMany | ||
| [ (TxOutKey txOutputTxId txOutputIndex, o) | ||
| | o@TxOut{..} <- txouts ] | ||
| forM_ (chunksOf chunkSize $ map txMetaTxId metas) $ \txids -> | ||
| deleteWhere [ TxMetadataTxId <-. txids ] |
There was a problem hiding this comment.
Why the delete? Isn't the point of repsert to "replace or insert"?
| , concatMap (fst . (\(_,b,_,_) -> b)) entities | ||
| , concatMap (snd . (\(_,b,_,_) -> b)) entities | ||
| , concatMap (\(_,_,c,_) -> maybeToList c) entities | ||
| , concatMap (\(_,_,_,d) -> d) entities | ||
| ) |
There was a problem hiding this comment.
Wouldn't be more efficient and simpler to store metadata with the rest of the static data (status, direction etc..)?
We have to resort to separate database tables for TxIn, TxOut and TxWithdrawals because they are unbounded (modulo tx size) lists. Metadata however can be treated as a bunch of bytes that are either present or not.
There was a problem hiding this comment.
My reason was just that sqlite tables don't cost much and it seemed like it would be confusing to have data in the TxMeta table which was actually a field of Tx.
| txMetadataValue W.TxMetadata sql=value | ||
|
|
||
| Primary txMetadataTxId | ||
| deriving Show Generic |
There was a problem hiding this comment.
I am a bit doubtful about having this as a separate table (cf earlier comment).
KtorZ
force-pushed
the
rvl/2072/sqlite-tx-metadata
branch
from
8c98ca5 to
c43d093
Compare
This is more efficient than storing them in separate tables like inputs and outputs and also a bit less awkward when it comes to fetching metadata corresponding to each transactions back.
|
Thanks bors r+ |
Build succeeded |
Issue Number
ADP-307 / #2072
Overview
Includes transaction metadata in the sqlite database transaction history.
Comments