Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TxMetadata to API #2089

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Add TxMetadata to API #2089

merged 3 commits into from
Sep 2, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Aug 28, 2020 •
edited
Loading

Issue Number

ADP-307 / #2073 / #2074

Overview

Add TxMetadata to API.

Comments

  • Still in draft because API swagger tests are failing. It's not liking the schema references.

@rvl rvl added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Aug 28, 2020
@rvl rvl added this to the (ADP-307) Transaction metadata milestone Aug 28, 2020
@rvl rvl self-assigned this Aug 28, 2020
@rvl rvl mentioned this pull request Aug 28, 2020
Merged
@rvl rvl force-pushed the rvl/2073/api-tx-metadata branch from 7915e03 to bbe8fec Compare August 28, 2020 12:40
@rvl rvl changed the base branch from rvl/2077/tx-metadata to rvl/2073/mkstdtx August 28, 2020 12:42
@rvl rvl force-pushed the rvl/2073/api-tx-metadata branch from bbe8fec to 15a5869 Compare August 28, 2020 12:48
@rvl rvl force-pushed the rvl/2073/mkstdtx branch 3 times, most recently from 1ef320e to 30d70f6 Compare September 1, 2020 05:39
@rvl rvl force-pushed the rvl/2073/api-tx-metadata branch from 15a5869 to 7822364 Compare September 1, 2020 05:46
Base automatically changed from rvl/2073/mkstdtx to master September 1, 2020 09:29
@rvl rvl force-pushed the rvl/2073/api-tx-metadata branch 3 times, most recently from 937f1df to 5b2559e Compare September 2, 2020 05:46
@rvl rvl force-pushed the rvl/2073/api-tx-metadata branch from 5b2559e to 039372f Compare September 2, 2020 11:19
@rvl rvl mentioned this pull request Sep 2, 2020
Closed
@KtorZ KtorZ self-requested a review September 2, 2020 11:56
KtorZ
KtorZ approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and fixed the swagger spec verification. The test is rather weak since the swagger2 library we use relies on OpenAPI 2.0 schemas which do not support the oneOf combinator... So right now, the only check we can really do on metadata is that they are any valid JSON... which is on the other hand, pretty much all we care about.

@KtorZ KtorZ marked this pull request as ready for review September 2, 2020 13:09
@KtorZ
Copy link
Member

KtorZ commented Sep 2, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 2, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 63f02a9 into master Sep 2, 2020
@iohk-bors iohk-bors bot deleted the rvl/2073/api-tx-metadata branch September 2, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@rvl rvl

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-307) Transaction metadata
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @KtorZ