-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ? placeholder syntax in listRetiredPools
.
#2053
Merged
iohk-bors
merged 2 commits into
master
from
jonathanknowles/use-placeholders-in-sql-queries
Aug 20, 2020
Merged
Use ? placeholder syntax in listRetiredPools
.
#2053
iohk-bors
merged 2 commits into
master
from
jonathanknowles/use-placeholders-in-sql-queries
Aug 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
2 tasks
This comment has been minimized.
This comment has been minimized.
KtorZ
approved these changes
Aug 20, 2020
bors try |
jonathanknowles
added
the
IMPROVEMENT
Mark a PR as an improvement, for auto-generated CHANGELOG
label
Aug 20, 2020
jonathanknowles
added this to the (ADP-376) Garbage collection of retired pools from the DB milestone
Aug 20, 2020
bors cancel |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 20, 2020
2053: Use ? placeholder syntax in `listRetiredPools`. r=jonathanknowles a=jonathanknowles # Issue Number #2016 # Overview This PR adjusts `listRetiredPools` to use the `?` placeholder syntax when constructing a raw SQL query. Co-authored-by: Jonathan Knowles <[email protected]>
Build failed |
bors retry |
tryBuild succeeded |
Build succeeded |
iohk-bors
bot
deleted the
jonathanknowles/use-placeholders-in-sql-queries
branch
August 20, 2020 10:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#2016
Overview
This PR adjusts
listRetiredPools
to use the?
placeholder syntax when constructing a raw SQL query.