Fix restore bench and docker #2045

Anviking · 2020-08-16T18:57:05Z

Issue Number

#1919, #2044

Overview

Fix broken restore bench https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/608#f02f336b-c7be-4b3f-b86b-bc825c9b5ac2
Hope docker should be fixed, but can't easily test locally ⚠️

Comments

rvl · 2020-08-17T10:02:23Z

nix/docker.nix

-    exec ${exe}/bin/cardano-wallet-${backend} "$@"
-  '';
+      export LOCALE_ARCHIVE="${glibcLocales}/lib/locale/locale-archive"
+      exec ${exe}/bin/${walletExeName} "$@"


Since it's a bash script, you could "cheat" and use a glob.

exec ${exe}/bin/cardano-wallet* "$@"

On second thought, that would break if we for some reason would end up with multiple matches?

If the cost is the two lines:

suffix = if backend == "shelley" then "" else "-" + backend; walletExeName = "cardano-wallet" + suffix;

then maybe being explicit is worth it.

The glob will be safe to use because this is the bin directory within a backend-specific package. But explicit filenames are probably easier to maintain.

nix/docker.nix

rvl · 2020-08-17T10:04:55Z

nix/docker.nix

+    let
+      suffix = if backend == "shelley" then "" else "-" + backend;
+      walletExeName = "cardano-wallet" + suffix;
+    in writeScriptBin "start-cardano-wallet-${backend}" ''


The name of this start script actually doesn't matter. It could be called globbits and the image would still work.
So you can remove the backend from its name.

This I noticed, but in-doubt kept the name as before.

start-cardano-wallet could make you believe it was shelley specific, even when the backend is jormungandr.

Maybe just start or start-wallet?

I went with start-wallet now.

nix/docker.nix

rvl · 2020-08-18T00:00:43Z

Looks good, works for me.

bors r+

2045: Fix restore bench and docker r=rvl a=Anviking # Issue Number #1919, #2044 # Overview  - [x] Fix broken restore bench https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/608#f02f336b-c7be-4b3f-b86b-bc825c9b5ac2 - [ ] _Hope_ `docker` should be fixed, but can't easily test locally ⚠️ # Comments   Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2020-08-18T01:02:27Z

Build failed

buildkite/cardano-wallet

cardano-wallet-2020.8.3: test (suite: integration, args: --skip SERIAL)
cardano-wallet-cli-2020.8.3: test (suite: unit, args: --skip SERIAL)
cardano-wallet-core-2020.8.3: test (suite: unit, args: --skip SERIAL)
cardano-wallet-jormungandr-2020.8.3: test (suite: unit, args: --skip SERIAL)
text-class-2020.8.3: test (suite: unit, args: --skip SERIAL)
cardano-wallet-launcher-2020.8.3: test (suite: unit, args: --skip SERIAL)
text-class-2020.8.3: Test suite unit passed
cardano-wallet-cli-2020.8.3: Test suite unit passed
cardano-wallet-launcher-2020.8.3: Test suite unit passed
cardano-wallet-jormungandr-2020.8.3: Test suite unit passed
cardano-wallet-core-2020.8.3: Test suite unit failed
Progress 5/6: cardano-wallet-2020.8.3
Timed out after 45 minutes.

Retry:

  | 1) API Specifications STAKE_POOLS_JOIN_05 - Can join when stake key already exists
  | uncaught exception: RequestException
  | DecodeFailure "Error in $: parsing Cardano.Wallet.Api.Types.ApiWallet(ApiWallet) failed, key \"id\" not found: Response {responseStatus = Status {statusCode = 409, statusMessage = \"Conflict\"}, responseVersion = HTTP/1.1, responseHeaders = [(\"Transfer-Encoding\",\"chunked\"),(\"Date\",\"Tue, 18 Aug 2020 06:38:52 GMT\"),(\"Server\",\"Warp/3.3.5\")], responseBody = \"{\\\"code\\\":\\\"wallet_already_exists\\\",\\\"message\\\":\\\"This operation would yield a wallet with the following id: 2a793eb367d44a42f658eb02d1004f50c14612fd However, I already know of a wallet with this id.\\\"}\", responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}"
  |  
  | To rerun use: --match "/API Specifications/STAKE_POOLS_JOIN_05 - Can join when stake key already exists/"
  |  
  | Randomized with seed 1077456383

Anviking · 2020-08-18T06:55:48Z

bors r+

2045: Fix restore bench and docker r=Anviking a=Anviking # Issue Number #1919, #2044 # Overview  - [x] Fix broken restore bench https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/608#f02f336b-c7be-4b3f-b86b-bc825c9b5ac2 - [ ] _Hope_ `docker` should be fixed, but can't easily test locally ⚠️ # Comments   Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2020-08-18T09:06:08Z

Timed out

Anviking · 2020-08-18T09:06:26Z

bors r+

2045: Fix restore bench and docker r=Anviking a=Anviking # Issue Number #1919, #2044 # Overview  - [x] Fix broken restore bench https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/608#f02f336b-c7be-4b3f-b86b-bc825c9b5ac2 - [ ] _Hope_ `docker` should be fixed, but can't easily test locally ⚠️ # Comments   Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2020-08-18T10:04:39Z

Build failed

buildkite/cardano-wallet

core:unit is stuck here:

    Extra Properties about DB initialization
      createWallet . listWallets yields expected results
        +++ OK, passed 100 tests.
      creating same wallet twice yields an error
        +++ OK, passed 100 tests.
      removing the same wallet twice yields an error
        +++ OK, passed 100 tests.
    put . read yields a result
      Checkpoint
        +++

Anviking · 2020-08-18T10:19:45Z

bors r+

2045: Fix restore bench and docker r=Anviking a=Anviking # Issue Number #1919, #2044 # Overview  - [x] Fix broken restore bench https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/608#f02f336b-c7be-4b3f-b86b-bc825c9b5ac2 - [ ] _Hope_ `docker` should be fixed, but can't easily test locally ⚠️ # Comments   Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2020-08-18T11:06:16Z

Build failed

buildkite/cardano-wallet


src/Test/Integration/Scenario/API/Byron/Migrations.hs:210:5:
--
  | 1) API Specifications BYRON_MIGRATE_01 -  migrate a big wallet requiring more than one tx
  | uncaught exception: RequestException
  | DecodeFailure "Error in $: parsing Cardano.Wallet.Api.Types.ApiByronWallet(ApiByronWallet) failed, key \"id\" not found: Response {responseStatus = Status {statusCode = 409, statusMessage = \"Conflict\"}, responseVersion = HTTP/1.1, responseHeaders = [(\"Transfer-Encoding\",\"chunked\"),(\"Date\",\"Tue, 18 Aug 2020 10:40:48 GMT\"),(\"Server\",\"Warp/3.3.5\")], responseBody = \"{\\\"code\\\":\\\"wallet_already_exists\\\",\\\"message\\\":\\\"This operation would yield a wallet with the following id: 0b3a38e4078206ccd93cc353a93cc3a37dbbb4fe However, I already know of a wallet with this id.\\\"}\", responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}"
  |  
  | To rerun use: --match "/API Specifications/BYRON_MIGRATE_01 -  migrate a big wallet requiring more than one tx/"
  |  
  | Randomized with seed 279501919

Anviking · 2020-08-18T11:09:30Z

bors r+

iohk-bors · 2020-08-18T12:08:52Z

Build succeeded

Hopefully fix restore bench after renaming executable

0731cea

Anviking self-assigned this Aug 17, 2020

Anviking force-pushed the anviking/1919/fix-restore branch 2 times, most recently from c875084 to edbcefc Compare August 17, 2020 09:43

Anviking marked this pull request as ready for review August 17, 2020 09:44

Anviking force-pushed the anviking/1919/fix-restore branch from edbcefc to 13c55e0 Compare August 17, 2020 09:45

Anviking requested a review from rvl August 17, 2020 09:49

rvl reviewed Aug 17, 2020

View reviewed changes

Anviking force-pushed the anviking/1919/fix-restore branch 2 times, most recently from 0244e35 to d718f30 Compare August 17, 2020 14:06

Try to fix docker

783f6f1

Anviking force-pushed the anviking/1919/fix-restore branch from d718f30 to 783f6f1 Compare August 17, 2020 14:08

rvl added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Aug 17, 2020

rvl approved these changes Aug 18, 2020

View reviewed changes

rvl mentioned this pull request Aug 18, 2020

Nightly restoration benchmark are silently failing for 1% wallets #2022

Closed

iohk-bors bot merged commit 1d7914c into master Aug 18, 2020

iohk-bors bot deleted the anviking/1919/fix-restore branch August 18, 2020 12:08

rvl mentioned this pull request Aug 24, 2020

Remove cardano-wallet-byron package #1919

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix restore bench and docker #2045

Fix restore bench and docker #2045

Anviking commented Aug 16, 2020 •

edited

Loading

rvl Aug 17, 2020

Anviking Aug 17, 2020

rvl Aug 18, 2020

rvl Aug 17, 2020

Anviking Aug 17, 2020

Anviking Aug 17, 2020

rvl commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020 •

edited by Anviking

Loading

Anviking commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020

Anviking commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020 •

edited by Anviking

Loading

Anviking commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020 •

edited by Anviking

Loading

Anviking commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020

Fix restore bench and docker #2045

Fix restore bench and docker #2045

Conversation

Anviking commented Aug 16, 2020 • edited Loading

Issue Number

Overview

Comments

rvl Aug 17, 2020

Choose a reason for hiding this comment

Anviking Aug 17, 2020

Choose a reason for hiding this comment

rvl Aug 18, 2020

Choose a reason for hiding this comment

rvl Aug 17, 2020

Choose a reason for hiding this comment

Anviking Aug 17, 2020

Choose a reason for hiding this comment

Anviking Aug 17, 2020

Choose a reason for hiding this comment

rvl commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020 • edited by Anviking Loading

Build failed

Anviking commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020

Timed out

Anviking commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020 • edited by Anviking Loading

Build failed

Anviking commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020 • edited by Anviking Loading

Build failed

Anviking commented Aug 18, 2020

iohk-bors bot commented Aug 18, 2020

Build succeeded

Anviking commented Aug 16, 2020 •

edited

Loading

iohk-bors bot commented Aug 18, 2020 •

edited by Anviking

Loading

iohk-bors bot commented Aug 18, 2020 •

edited by Anviking

Loading

iohk-bors bot commented Aug 18, 2020 •

edited by Anviking

Loading