Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cardano-wallet-byron package #2012

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Remove cardano-wallet-byron package #2012

merged 1 commit into from
Aug 10, 2020

Conversation

Anviking
Copy link
Member

Issue Number

#1919

Overview

  • rm -rf lib/byron
  • Remove nix and CI stuff relating to it

Comments

Since cardano-wallet-shelley is now targeting the mainnet, we can remove
the byron package.

We should perhaps concider renaming cardano-wallet-shelley to simply
cardano-wallet.

@Anviking
Remove cardano-wallet-byron package
bb92ae8 
Since cardano-wallet-shelley is now targeting the mainnet, we can remove
the byron package.

We should perhaps concider renaming cardano-wallet-shelley to simply
cardano-wallet.
@Anviking Anviking self-assigned this Aug 10, 2020
KtorZ
KtorZ approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also make sure that the Wiki is cleaned up?

@Anviking Anviking marked this pull request as ready for review August 10, 2020 09:41
@Anviking
Copy link
Member Author

Buildkite seems happy:
bors r+

Wiki updated:

commit b3dc57635ab476a7ec3bcc086b5596de78186ef3 (HEAD -> master, origin/master, origin/HEAD)
Author: Johannes Lund <[email protected]>
Date:   Mon Aug 10 11:40:15 2020 +0200

    Remove occurences of cardano-wallet-byron

    Since we are about to remove it.

@rvl rvl mentioned this pull request Aug 10, 2020
Closed
9 tasks
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 10, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit a7670ed into master Aug 10, 2020
@iohk-bors iohk-bors bot deleted the anviking/1919/remove-byron-package branch August 10, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
(ADP-356) Integration with Hard Fork ...
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @KtorZ