Relax coverage check for prop_rollbackRetirement.
#1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, QuickCheck would typically need to test this property
many thousands of times in order to satisfy the coverage check. Here's a
particularly bad example (taking 36 seconds to complete on my system):
rollback of PoolRetirement
+++ OK, passed 12800 tests:
95.000% length expectedPublications > 0
67.633% 0 < length expectedPublications < length allPublications
59.617% rollbackPoint = slotMinBound
40.383% rollbackPoint > slotMinBound
5.000% length expectedPublications = 0
After this change, QuickCheck is able to satisfy the coverage check
after only a few hundred tests:
rollback of PoolRetirement
+++ OK, passed 400 tests:
94.0% length expectedPublications > 0
71.0% 0 < length expectedPublications < length allPublications
60.8% rollbackPoint = slotMinBound
39.2% rollbackPoint > slotMinBound
6.0% length expectedPublications = 0
erikd
approved these changes
Jul 27, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 27, 2020
1957: Relax coverage check for `prop_rollbackRetirement`. r=jonathanknowles a=jonathanknowles
# Issue Number
None.
# Summary
This PR relaxes the coverage check for the `prop_rollbackRetirement` property.
Before applying this change, QuickCheck would typically need to test this property _many thousands of times_ in order to satisfy the coverage check.
Here's a particularly bad example (taking 36 seconds to complete on my system):
```hs
rollback of PoolRetirement
+++ OK, passed 12800 tests:
95.000% length expectedPublications > 0
67.633% 0 < length expectedPublications < length allPublications
59.617% rollbackPoint = slotMinBound
40.383% rollbackPoint > slotMinBound
5.000% length expectedPublications = 0
```
After this change, QuickCheck is able to satisfy the coverage check after only a few hundred tests:
```hs
rollback of PoolRetirement
+++ OK, passed 400 tests:
94.0% length expectedPublications > 0
71.0% 0 < length expectedPublications < length allPublications
60.8% rollbackPoint = slotMinBound
39.2% rollbackPoint > slotMinBound
6.0% length expectedPublications = 0
```
Co-authored-by: Jonathan Knowles <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
None.
Summary
This PR relaxes the coverage check for the
prop_rollbackRetirementproperty.Before applying this change, QuickCheck would typically need to test this property many thousands of times in order to satisfy the coverage check.
Here's a particularly bad example (taking 36 seconds to complete on my system):
After this change, QuickCheck is able to satisfy the coverage check after only a few hundred tests: