Basic integration tests for pool registrations and retirements. #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
added
the
IMPROVEMENT
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
piotr-iohk
reviewed
Jul 20, 2020
lib/core-integration/src/Test/Integration/Scenario/API/Shelley/StakePools.hs
Outdated
Show resolved
Hide resolved
jonathanknowles
force-pushed
the
jonathanknowles/basic-pool-registration-retirement-integration-tests
branch
from
f06cca4 to
b6cdeea
Compare
jonathanknowles
added a commit
that referenced
this pull request
Jul 21, 2020
For now, we actually want all test stake pools to remain alive for the full duration of an integration test suite run, hence we configure our test pools to have retirement dates that are well into the future. In future, we will add more tests to simulate what happens after a stake pool has retired. In response to review feedback: #1931 (comment)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Justification: later on, we will need to distinguish between different types of pool certificate.
(For testing purposes only.)
For now, we actually want all test stake pools to remain alive for the full duration of an integration test suite run, hence we configure our test pools to have retirement dates that are well into the future. In future, we will add more tests to simulate what happens after a stake pool has retired. In response to review feedback: #1931 (comment)
Justification: this is an informational notice to assist with debugging. (A disclaimer would be appropriate if it were necessary to limit the scope of legal liability in some way, but that doesn't appear to be necessary here.)
jonathanknowles
force-pushed
the
jonathanknowles/basic-pool-registration-retirement-integration-tests
branch
from
b64aa21 to
228f2a7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
piotr-iohk
approved these changes
Jul 21, 2020
|
bors r+ |
Build succeeded |
iohk-bors
bot
deleted the
jonathanknowles/basic-pool-registration-retirement-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1819
Overview
This PR provides a first step towards a full suite of integration tests for pool registrations and retirements.
issuePoolRetirementCertcapable of creating Shelley pool retirement certificates.ListStakePoolsAPI operation eventually shows the correct retirement epochs for the test pools.Comments
Future PRs will: