bors: Remove ci/hydra-eval from required statuses #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we've seen several Bors merge failures from ci/hydra-eval
that terminate with
error: unable to fork: Cannot allocate memory
This works around the issue (#1888) by removing ci/hydra-eval from
statuses required for Bors to merge.
This status will instead be added as a requirement to the GitHub
branch protection rules of this repo.
If the Hydra eval fails the first time around for the Bors merge
commit, Bors won't fail because eval isn't required for Bors
anymore. Hydra will automatically fix the eval, likely on the second
pass, and then build the job at which point Bors will get the build
notification and merge assuming the build is fine (which it should be
if the PR CI status is already passed).
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 18, 2020
1922: bors: Remove ci/hydra-eval from required statuses r=rvl a=rvl ### Issue Number Partial workaround for #1888. ### Overview Recently we've seen several Bors merge failures from `ci/hydra-eval` that terminate with error: unable to fork: Cannot allocate memory This works around the issue by removing `ci/hydra-eval` from statuses required for Bors to merge. This status will instead be added as a requirement to the GitHub branch protection rules of this repo. If the Hydra eval fails the first time around for the Bors merge commit, Bors won't fail because eval isn't required for Bors anymore. Hydra will automatically fix the eval, likely on the second pass, and then build the job at which point Bors will get the build notification and merge assuming the build is fine (which it should be if the PR CI status is already passed). Co-authored-by: Rodney Lorrimar <[email protected]>
Build failedJob Cardano:cardano-wallet-bors-staging:native.checks.cardano-wallet-core.unit.x86_64-darwin timed out after 15 minutes. |
paweljakubas
approved these changes
Jul 18, 2020
|
bors retry |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Partial workaround for #1888.
Overview
Recently we've seen several Bors merge failures from
ci/hydra-evalthat terminate withThis works around the issue by removing
ci/hydra-evalfrom statuses required for Bors to merge.This status will instead be added as a requirement to the GitHub branch protection rules of this repo.
If the Hydra eval fails the first time around for the Bors merge commit, Bors won't fail because eval isn't required for Bors anymore. Hydra will automatically fix the eval, likely on the second pass, and then build the job at which point Bors will get the build notification and merge assuming the build is fine (which it should be if the PR CI status is already passed).