Less verbose LSQ pool response trace #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Jul 6, 2020
| @@ -381,6 +381,9 @@ withNetworkLayer tr np addrInfo versionData action = do | |||
| (optimumNumberOfPools pparams) | |||
| rewardMap | |||
| stakeMap | |||
| liftIO $ traceWith tr $ MsgFetchedNodePoolLsqDataSummary | |||
| (Map.size stakeMap) | |||
| (Map.size rewardMap) | |||
| liftIO $ traceWith tr $ MsgFetchedNodePoolLsqData res | |||
There was a problem hiding this comment.
That's one way to do it, what about using only a single message, and depending on the severity, show either the full result, or a summary :) ?
There was a problem hiding this comment.
That was how I first imagined it, but I don't see how.
We need to provide a severity, given a MsgFetchedNodePoolLsqData. Not the other way around. We don't know the global severity level.
There was a problem hiding this comment.
Hmmm... right, the ToText instance is actually not aware of the severity!
Anviking
commented
Jul 6, 2020
| @@ -724,6 +727,9 @@ data NetworkLayerLog | |||
| | MsgDestroyCursor ThreadId | |||
| | MsgWillQueryRewardsForStake W.Coin | |||
| | MsgFetchedNodePoolLsqData NodePoolLsqData | |||
| | MsgFetchedNodePoolLsqDataSummary Int Int | |||
There was a problem hiding this comment.
Wish we had some kind of anonymous records / named-tuples (e.g. (stakeDistrSize :: Int, rewardMapSize :: Int)) for situations like these :/
Think a separate record-type is overkill and not sure Quantity "pools in stakeDistr" helps that much. Or maybe the latter?
There was a problem hiding this comment.
anonymous records / named-tuples
Yeah! One of the thing I really like in Elm <3
KtorZ
approved these changes
Jul 6, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 6, 2020
1864: Less verbose LSQ pool response trace r=Anviking a=Anviking # Overview - [x] Log the full response as DEBUG, not INFO - [x] Log the _size_ of the stake distribution and reward map as INFO # Comments We now see: ``` [cardano-wallet.network:Info:65] [2020-07-06 15:07:56.63 UTC] Will query non-myopic rewards using the stake 100000000000 [cardano-wallet.network:Info:65] [2020-07-06 15:07:56.82 UTC] Fetched pool data from node tip using LSQ. Got 360 pools in the stake distribution, and 360 pools in the non-myopic member reward map. ``` With: ``` --trace-network=DEBUG ``` we still see the full response. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
Build failed |
We now see: ``` [cardano-wallet.network:Info:65] [2020-07-06 15:07:56.63 UTC] Will query non-myopic rewards using the stake 100000000000 [cardano-wallet.network:Info:65] [2020-07-06 15:07:56.82 UTC] Fetched pool data from node tip using LSQ. Got 360 pools in the stake distribution, and 360 pools in the non-myopic member reward map. ``` With: --trace-network=DEBUG we still see the full response.
Anviking
force-pushed
the
anviking/less-verbose-pool-traces
branch
from
2a3115d to
8321139
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 6, 2020
1864: Less verbose LSQ pool response trace r=Anviking a=Anviking # Overview - [x] Log the full response as DEBUG, not INFO - [x] Log the _size_ of the stake distribution and reward map as INFO # Comments We now see: ``` [cardano-wallet.network:Info:65] [2020-07-06 15:07:56.63 UTC] Will query non-myopic rewards using the stake 100000000000 [cardano-wallet.network:Info:65] [2020-07-06 15:07:56.82 UTC] Fetched pool data from node tip using LSQ. Got 360 pools in the stake distribution, and 360 pools in the non-myopic member reward map. ``` With: ``` --trace-network=DEBUG ``` we still see the full response. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
Build failed |
piotr-iohk
approved these changes
Jul 7, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Comments
We now see:
With:
we still see the full response.