Add more debug-level chain-sync- and follow traces #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
added
the
IMPROVEMENT
KtorZ
reviewed
Jun 30, 2020
| step delay0 hasRolledForward cursor' | ||
| (sl, _:_, False) | sl == slotId (last cps) -> do | ||
| traceWith tr $ MsgWillIgnoreRollback sl "initial rollback, \ | ||
| \rollback point equals the last checkpoing" |
| @@ -348,6 +361,7 @@ chainSyncWithBlocks fromTip queue responseBuffer = | |||
| -> P.ClientStNext n block (Tip block) m Void | |||
| collectResponses respond blocks Zero = P.ClientStNext | |||
| { P.recvMsgRollForward = \block tip -> do | |||
| traceWith tr $ MsgChainRollForward block | |||
There was a problem hiding this comment.
Logging every rollForward sounds like something that would cause great slowness. Have you measured the syncing time against mainnet and a non-null tracer on the Byron wallets?
There was a problem hiding this comment.
These logs should't be visible per default since they are marked Debug — but perhaps still worth a check. Haven't tried yet…
There was a problem hiding this comment.
We had the case in the past, where simply having a logger would cause tremendous performance regression because the system still needs, on each block, to assess whether or not it should be logged.
Recent build from master: Looks like no noticeable change. @KtorZ, thoughts? |
|
Looks convincing enough :) |
KtorZ
approved these changes
Jul 10, 2020
KtorZ
force-pushed
the
anviking/more-traces
branch
from
4d782b3 to
3f8cdaf
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 10, 2020
1826: Add more debug-level chain-sync- and follow traces r=KtorZ a=Anviking # Issue Number Related to / was used to debug #1794 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> The chain-following code is complex. We usually log when the `follow` function asks us to roll forward or backward, but we don't have traces for the underlying logic. - [x] Trace when `follow` ignores (hopefully) idempotent rollbacks, and why - [x] Trace low-level chain-sync commands # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1887: Rename our SlotNo to SlotInEpoch r=KtorZ a=Anviking # Issue Number #1868 <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Renamed `SlotNo` to `SlotInEpoch` (for consistency with other components) # Comments - `W.SlotNo` == `Cardano.SlotInEpoch` /= `Cardano.SlotNo` ``` Epoch 0 1 2 3 4 SlotNo* 0 1 2 3 4 5 6 7 8 9 SlotInEpoch 0 1 0 1 0 1 0 1 0 1 ``` *) I.e. the one defined in cardano-base and used in ourobouros-consensus. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1895: hydra: Prevent caching of shelley integration test failures r=KtorZ a=rvl ### Issue Number Not sure. ### Overview This change causes integration tests to be re-run whenever the git revision changes, even if everything else is identical. Since these tests tend to fail a lot, we don't want to cache false failures. Also increase the minimum severity for integration test logging, because debug level produces quite a lot of output. Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed (retrying...) |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Related to / was used to debug #1794
Overview
The chain-following code is complex. We usually log when the
followfunction asks us to roll forward or backward, but we don't have traces for the underlying logic.followignores (hopefully) idempotent rollbacks, and whyComments