discard metadata URL based on their hash, not URLs #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
added
the
RESOLVING ISSUE
KtorZ
force-pushed
the
KtorZ/fix-metadata-blacklisting
branch
from
149c2a0 to
2f0aa23
Compare
disassembler
approved these changes
Jun 27, 2020
|
tested and this shows stake pools with multiple registrations right away! |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 27, 2020
1810: discard metadata URL based on their hash, not URLs r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1805 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have changed the SQLite filtering to discard metadata URL based on their hash, not URLs <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
|
bors retry |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 27, 2020
1810: discard metadata URL based on their hash, not URLs r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1805 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have changed the SQLite filtering to discard metadata URL based on their hash, not URLs <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
KtorZ
force-pushed
the
KtorZ/fix-metadata-blacklisting
branch
from
2f0aa23 to
c702f82
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 27, 2020
1810: discard metadata URL based on their hash, not URLs r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1805 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have changed the SQLite filtering to discard metadata URL based on their hash, not URLs <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
|
I opened issue #1811 about the test which just failed in bors - retrying now. bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 28, 2020
1810: discard metadata URL based on their hash, not URLs r=rvl a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1805 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have changed the SQLite filtering to discard metadata URL based on their hash, not URLs <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
|
Doh, forgot that the test result is cached - restarted the test build in Hydra. bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1805
Overview