Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More mnemonics for icarus/random wallets #1809

Merged
merged 3 commits into from
Jun 27, 2020

Conversation

paweljakubas
Copy link
Contributor

Issue Number

#1803

Overview

  • I have enabled more mnemonics lengths for random/icarus wallets
  • I have updated swagger and Malformed in core unit tests
  • I have updated byron integration scenarios

Comments

@paweljakubas
Copy link
Contributor Author

bors try

iohk-bors bot added a commit that referenced this pull request Jun 27, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 27, 2020

@paweljakubas paweljakubas requested review from KtorZ and piotr-iohk June 27, 2020 11:54
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @paweljakubas

it' "icarus" (genMnemonics @24) scenarioFailure --
it' "icarus" (genMnemonics @18) scenarioSuccess -- ✔️
it' "icarus" (genMnemonics @21) scenarioSuccess -- ✔️
it' "icarus" (genMnemonics @24) scenarioSuccess -- ✔️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems about right ✔️

@paweljakubas
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 27, 2020

@iohk-bors iohk-bors bot merged commit d1d635f into master Jun 27, 2020
@iohk-bors iohk-bors bot deleted the paweljakubas/1803/more-mnemonics-for-icarus-random branch June 27, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants