wire pool's 'pledge' from the registration certificate unto the Api #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can add a check in the integration tests though. |
KtorZ
force-pushed
the
KtorZ/1719/pool-pledge
branch
from
0c61540 to
36bff35
Compare
Anviking
force-pushed
the
KtorZ/1719/pool-pledge
branch
from
36bff35 to
5a2d807
Compare
KtorZ
force-pushed
the
KtorZ/1719/pool-pledge
branch
from
bc64b40 to
cca237b
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 26, 2020
1800: wire pool's 'pledge' from the registration certificate unto the Api r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1719 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 027ce66 📍 **wire pool's 'pledge' from the registration certificate unto the Api** - 37384c6 📍 **fix typo in swagger documentation 'ommitted' -> 'omitted'** - 0c61540 📍 **add integration test showing that pledge is correctly discovered** # Comments <!-- Additional comments or screenshots to attach if any -->  <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
|
bors retry |
KtorZ
added
the
ADDING FEATURE
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1719
Overview
027ce66
📍 wire pool's 'pledge' from the registration certificate unto the Api
37384c6
📍 fix typo in swagger documentation 'ommitted' -> 'omitted'
0c61540
📍 add integration test showing that pledge is correctly discovered
Comments