Fix logging in shelley integration test cluster #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/adp-302/fix-integration-tests-logging
branch
from
4cc66ca to
c4a2afc
Compare
rvl
force-pushed
the
rvl/adp-302/fix-integration-tests-logging
branch
from
c4a2afc to
472df30
Compare
KtorZ
added
the
RESOLVING ISSUE
KtorZ
reviewed
Jun 25, 2020
| @@ -409,6 +411,44 @@ withBFTNode tr baseDir (NodeParams severity systemStart (port, peers)) action = | |||
| name = "bft" | |||
| dir = baseDir </> name | |||
|
|
|||
| withPassiveNode | |||
There was a problem hiding this comment.
It could be nice to add a comment explaining why we are using this indirection.
KtorZ
approved these changes
Jun 25, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-302 / #1750
Overview
Block forging and adoption was not being logged by the integration tests cluster. Fixed it. The default minimum severity for stdout remains as Error. The default minimum severity for the log file is Debug.
This adds a passive node which the wallet connects to, rather than using the bft node. My hope is that this will cause transactions to be broadcast to all stake pools, meaning that transactions won't be lost with rollbacks. But in any case, this updated topology makes for a more "realistic" integration test.