Test that pools have non-myopic member rewards #1783

Anviking · 2020-06-22T15:01:10Z

Issue Number

#1276

Overview

Test that pools have non-zero non-myopic member rewards in GET /stake-pools
Test that pools are sorted by descending rewards
Add MsgWillQueryRewardsForStake trace

Comments

lib/shelley/test/data/cardano-node-shelley/genesis.yaml

Anviking · 2020-06-29T13:58:06Z

bors try

iohk-bors · 2020-06-29T14:27:18Z

try

Build failed

buildkite/cardano-wallet

Anviking · 2020-06-29T16:02:36Z

bors try

iohk-bors · 2020-06-29T16:33:41Z

try

Build failed

buildkite/cardano-wallet

If the ranking is weird, we can know what stake-value was used.

Fixup: Add todo about STAKE_POOLS_LIST_01 not passing in isolation Also test that pools are sorted

Anviking · 2020-06-29T17:11:05Z

bors try

Anviking · 2020-06-29T17:12:36Z

lib/shelley/src/Cardano/Wallet/Shelley/Network.hs

@@ -790,6 +792,8 @@ instance ToText NetworkLayerLog where
            [ "Destroying cursor connection at"
            , T.pack (show threadId)
            ]
+        MsgWillQueryRewardsForStake c ->
+            "Will query non-myopic rewards using the stake " <> pretty c


Is the balance private and not to be logged? (not necessarily the user's balance, but likely correlated)

Nope, fine. Balances are already logged as part of the wallet. Current logs aren't much private.

iohk-bors · 2020-06-29T17:42:17Z

try

Build failed

buildkite/cardano-wallet

KtorZ · 2020-06-30T09:53:58Z

(trying the branch locally)

KtorZ · 2020-06-30T10:02:44Z

bors r+

KtorZ · 2020-06-30T12:16:02Z

Locally, the test pass when run in isolation. But it fails when run with the entire test-suite. One of two conditions is not verified.

Anviking · 2020-06-30T16:14:30Z

It seems the pools all have the same non-myopic member rewards. Perhaps leaving them running for long removes the noise.

I tried giving one pool twice the amount of pledge/stake, and it seemed to work. But perhaps giving each pool different costs, or margins would be neater 🤔

Anviking · 2020-06-30T16:20:32Z

bors try

iohk-bors · 2020-06-30T16:50:08Z

try

Build failed

buildkite/cardano-wallet


1) API Specifications STAKE_POOLS_QUIT_02 - Passphrase must be correct to quit
--
  | [cardano-wallet.integration:Notice:785] [2020-06-30 16:48:18.28 UTC] bft [cardano-node.68006] Terminating child process
  | expected: Status {statusCode = 202, statusMessage = "Accepted"}
  | [cardano-wallet.integration:Notice:866] [2020-06-30 16:48:18.28 UTC] pool-1 [cardano-node.68243] Terminating child process
  | but got: Status {statusCode = 404, statusMessage = "Not Found"}
  |  
  | from the following response: Left (DecodeFailure "Error in $: parsing Cardano.Wallet.Api.Types.ApiTransaction(ApiTransaction) failed, key \"id\" not found: Response {responseStatus = Status {statusCode = 404, statusMessage = \"Not Found\"}, responseVersion = HTTP/1.1, responseHeaders = [(\"Transfer-Encoding\",\"chunked\"),(\"Date\",\"Tue, 30 Jun 2020 16:41:51 GMT\"),(\"Server\",\"Warp/3.3.5\")], responseBody = \"{\\\"code\\\":\\\"no_such_pool\\\",\\\"message\\\":\\\"I couldn't find any stake pool with the given id: ec28f33dcbe6d6400a1e5e339bd0647c0973ca6c0cf9c2bbe6838dc6\\\"}\", responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}")
  |  
  | To rerun use: --match "/API Specifications/STAKE_POOLS_QUIT_02 - Passphrase must be correct to quit/"
  |  
  | src/Test/Integration/Scenario/API/Shelley/StakePools.hs:187:5:
  | 2) API Specifications STAKE_POOLS_JOIN_01 - Can rejoin another stakepool
  | uncaught exception: RequestException
  | DecodeFailure "{\"code\":\"network_unreachable\",\"message\":\"The node backend is unreachable at the moment. Trying again in a bit might work.\"}"
  |  
  | To rerun use: --match "/API Specifications/STAKE_POOLS_JOIN_01 - Can rejoin another stakepool/"

Anviking · 2020-06-30T17:10:21Z

bors try

iohk-bors · 2020-06-30T17:32:50Z

try

Build failed

ci/hydra-build:required

Such that we can test that pools actually are ordered by descending rewards.

Anviking · 2020-06-30T18:40:30Z

bors try

iohk-bors · 2020-06-30T18:59:01Z

try

Build failed

ci/hydra-build:required

Anviking · 2020-06-30T19:24:46Z

bors try

iohk-bors · 2020-06-30T20:06:14Z

try

Build succeeded

Anviking · 2020-06-30T20:30:50Z

bors r+

iohk-bors · 2020-06-30T21:03:46Z

Build succeeded

Anviking commented Jun 22, 2020

View reviewed changes

lib/shelley/test/data/cardano-node-shelley/genesis.yaml Outdated Show resolved Hide resolved

Anviking mentioned this pull request Jun 22, 2020

Use and combine chain data with LSQ data for stake pools #1769

Merged

7 tasks

Anviking self-assigned this Jun 23, 2020

Anviking force-pushed the anviking/enable-rewards-test branch from 8ff53f2 to 636d4e4 Compare June 23, 2020 19:57

Anviking changed the title ~~Enable "Rewards accumulate and stop" test~~ Test that we see non-myopic member rewards, and actual rewards alike Jun 23, 2020

Anviking force-pushed the anviking/enable-rewards-test branch from 636d4e4 to 4c73df1 Compare June 26, 2020 14:40

Anviking changed the title ~~Test that we see non-myopic member rewards, and actual rewards alike~~ Test that pools have non-myopic member rewards Jun 26, 2020

Anviking mentioned this pull request Jun 26, 2020

Conflicting pool production #1796

Closed

Anviking force-pushed the anviking/enable-rewards-test branch 2 times, most recently from 0223947 to ec1fc6c Compare June 29, 2020 13:29

iohk-bors bot added a commit that referenced this pull request Jun 29, 2020

Try #1783:

6b19d6f

Anviking force-pushed the anviking/enable-rewards-test branch from ec1fc6c to 03ae72b Compare June 29, 2020 15:54

Anviking changed the base branch from master to rvl/adp-302/db-reward-balance June 29, 2020 15:59

Anviking marked this pull request as ready for review June 29, 2020 16:02

iohk-bors bot added a commit that referenced this pull request Jun 29, 2020

Try #1783:

46d5def

Anviking force-pushed the anviking/enable-rewards-test branch from 17b7799 to 30870fc Compare June 29, 2020 17:07

Anviking added 2 commits June 29, 2020 19:08

Add MsgWillQueryRewardsForStake trace

7910c25

If the ranking is weird, we can know what stake-value was used.

Test that pools have non-zero non-myopic member rewards

4f436a6

Fixup: Add todo about STAKE_POOLS_LIST_01 not passing in isolation Also test that pools are sorted

Anviking force-pushed the anviking/enable-rewards-test branch from 30870fc to 4f436a6 Compare June 29, 2020 17:09

iohk-bors bot added a commit that referenced this pull request Jun 29, 2020

Try #1783:

3c3ab89

Anviking commented Jun 29, 2020

View reviewed changes

Anviking requested a review from KtorZ June 29, 2020 17:16

Anviking added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Jun 29, 2020

Base automatically changed from rvl/adp-302/db-reward-balance to master June 30, 2020 09:36

KtorZ approved these changes Jun 30, 2020

View reviewed changes

iohk-bors bot added a commit that referenced this pull request Jun 30, 2020

Try #1783:

4408df9

iohk-bors bot added a commit that referenced this pull request Jun 30, 2020

Try #1783:

c3976ab

Give one pool more pledge to make it more desirable

367b626

Such that we can test that pools actually are ordered by descending rewards.

Anviking force-pushed the anviking/enable-rewards-test branch from 3bf90ac to 367b626 Compare June 30, 2020 18:21

iohk-bors bot added a commit that referenced this pull request Jun 30, 2020

Try #1783:

af048af

Tweak expectations to be nicer, and cause CI rebuild

5af4490

iohk-bors bot added a commit that referenced this pull request Jun 30, 2020

Try #1783:

cf7fad5

iohk-bors bot merged commit c493db9 into master Jun 30, 2020

iohk-bors bot deleted the anviking/enable-rewards-test branch June 30, 2020 21:03

Anviking mentioned this pull request Jul 1, 2020

Order stake pools by non-myopic member rewards #1720

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test that pools have non-myopic member rewards #1783

Test that pools have non-myopic member rewards #1783

Anviking commented Jun 22, 2020 •

edited

Loading

Anviking commented Jun 29, 2020

iohk-bors bot commented Jun 29, 2020

Anviking commented Jun 29, 2020

iohk-bors bot commented Jun 29, 2020

Anviking commented Jun 29, 2020

Anviking Jun 29, 2020 •

edited

Loading

KtorZ Jun 30, 2020

iohk-bors bot commented Jun 29, 2020

KtorZ commented Jun 30, 2020

KtorZ commented Jun 30, 2020

KtorZ commented Jun 30, 2020

Anviking commented Jun 30, 2020

Anviking commented Jun 30, 2020

iohk-bors bot commented Jun 30, 2020 •

edited by Anviking

Loading

Anviking commented Jun 30, 2020

iohk-bors bot commented Jun 30, 2020

Anviking commented Jun 30, 2020 •

edited

Loading

iohk-bors bot commented Jun 30, 2020

Anviking commented Jun 30, 2020

iohk-bors bot commented Jun 30, 2020

Anviking commented Jun 30, 2020

iohk-bors bot commented Jun 30, 2020

Test that pools have non-myopic member rewards #1783

Test that pools have non-myopic member rewards #1783

Conversation

Anviking commented Jun 22, 2020 • edited Loading

Issue Number

Overview

Comments

Anviking commented Jun 29, 2020

iohk-bors bot commented Jun 29, 2020

try

Build failed

Anviking commented Jun 29, 2020

iohk-bors bot commented Jun 29, 2020

try

Build failed

Anviking commented Jun 29, 2020

Anviking Jun 29, 2020 • edited Loading

Choose a reason for hiding this comment

KtorZ Jun 30, 2020

Choose a reason for hiding this comment

iohk-bors bot commented Jun 29, 2020

try

Build failed

KtorZ commented Jun 30, 2020

KtorZ commented Jun 30, 2020

KtorZ commented Jun 30, 2020

Anviking commented Jun 30, 2020

Anviking commented Jun 30, 2020

iohk-bors bot commented Jun 30, 2020 • edited by Anviking Loading

try

Build failed

Anviking commented Jun 30, 2020

iohk-bors bot commented Jun 30, 2020

try

Build failed

Anviking commented Jun 30, 2020 • edited Loading

iohk-bors bot commented Jun 30, 2020

try

Build failed

Anviking commented Jun 30, 2020

iohk-bors bot commented Jun 30, 2020

try

Build succeeded

Anviking commented Jun 30, 2020

iohk-bors bot commented Jun 30, 2020

Build succeeded

Anviking commented Jun 22, 2020 •

edited

Loading

Anviking Jun 29, 2020 •

edited

Loading

iohk-bors bot commented Jun 30, 2020 •

edited by Anviking

Loading

Anviking commented Jun 30, 2020 •

edited

Loading