re-use optparse applicative definitions from cardano-addresses #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
changed the title
KtorZ
added
the
IMPROVEMENT
rvl
approved these changes
Jun 19, 2020
|
bors try |
tryBuild failed |
KtorZ
force-pushed
the
KtorZ/cardano-address-command-reuse
branch
from
16c741f to
6b95bdc
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 19, 2020
1780: re-use optparse applicative definitions from cardano-addresses r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 996bc32 📍 **bump cardano-addresses revision in stack.yaml** To include most recent changes and in particular, the revised command-line for addresses and key derivation. - 4d4c1a8 📍 **re-use 'key' and 'recovery-phrase' commands from cardano-addresses** cardano-addresses also has some great extensive tests for these commands, which means that a lot of tests and code in cardano-wallet is now redundant. So I removed them. - 16c741f 📍 **remove redundant dependencies and weeds** # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
|
bors r+ |
Merge conflict |
To include most recent changes and in particular, the revised command-line for addresses and key derivation.
cardano-addresses also has some great extensive tests for these commands, which means that a lot of tests and code in cardano-wallet is now redundant. So I removed them.
KtorZ
force-pushed
the
KtorZ/cardano-address-command-reuse
branch
from
be76b36 to
52f4c7c
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 19, 2020
1764: Implement the estimation of maximum number of inputs for Shelley and show big wallet migration r=KtorZ a=paweljakubas # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1751 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have refactored computeTxSize to use later - [x] I have implemented `_estimateMaximumNumberOfInputs` - [x] I have unpended integration test showing the case - big wallet migration - [x] I have added property tests # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1780: re-use optparse applicative definitions from cardano-addresses r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 996bc32 📍 **bump cardano-addresses revision in stack.yaml** To include most recent changes and in particular, the revised command-line for addresses and key derivation. - 4d4c1a8 📍 **re-use 'key' and 'recovery-phrase' commands from cardano-addresses** cardano-addresses also has some great extensive tests for these commands, which means that a lot of tests and code in cardano-wallet is now redundant. So I removed them. - 16c741f 📍 **remove redundant dependencies and weeds** # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: KtorZ <[email protected]>
|
This PR was included in a batch that was canceled, it will be automatically retried |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 19, 2020
1764: Implement the estimation of maximum number of inputs for Shelley and show big wallet migration r=KtorZ a=paweljakubas # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1751 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have refactored computeTxSize to use later - [x] I have implemented `_estimateMaximumNumberOfInputs` - [x] I have unpended integration test showing the case - big wallet migration - [x] I have added property tests # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1780: re-use optparse applicative definitions from cardano-addresses r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 996bc32 📍 **bump cardano-addresses revision in stack.yaml** To include most recent changes and in particular, the revised command-line for addresses and key derivation. - 4d4c1a8 📍 **re-use 'key' and 'recovery-phrase' commands from cardano-addresses** cardano-addresses also has some great extensive tests for these commands, which means that a lot of tests and code in cardano-wallet is now redundant. So I removed them. - 16c741f 📍 **remove redundant dependencies and weeds** # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: KtorZ <[email protected]> Co-authored-by: IOHK <[email protected]>
|
This PR was included in a batch that was canceled, it will be automatically retried |
KtorZ
force-pushed
the
KtorZ/cardano-address-command-reuse
branch
from
52f4c7c to
8c9aa28
Compare
Canceled |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 19, 2020
1764: Implement the estimation of maximum number of inputs for Shelley and show big wallet migration r=KtorZ a=paweljakubas # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1751 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have refactored computeTxSize to use later - [x] I have implemented `_estimateMaximumNumberOfInputs` - [x] I have unpended integration test showing the case - big wallet migration - [x] I have added property tests # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1780: re-use optparse applicative definitions from cardano-addresses r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 996bc32 📍 **bump cardano-addresses revision in stack.yaml** To include most recent changes and in particular, the revised command-line for addresses and key derivation. - 4d4c1a8 📍 **re-use 'key' and 'recovery-phrase' commands from cardano-addresses** cardano-addresses also has some great extensive tests for these commands, which means that a lot of tests and code in cardano-wallet is now redundant. So I removed them. - 16c741f 📍 **remove redundant dependencies and weeds** # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: KtorZ <[email protected]> Co-authored-by: IOHK <[email protected]>
Build failed (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 19, 2020
1780: re-use optparse applicative definitions from cardano-addresses r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 996bc32 📍 **bump cardano-addresses revision in stack.yaml** To include most recent changes and in particular, the revised command-line for addresses and key derivation. - 4d4c1a8 📍 **re-use 'key' and 'recovery-phrase' commands from cardano-addresses** cardano-addresses also has some great extensive tests for these commands, which means that a lot of tests and code in cardano-wallet is now redundant. So I removed them. - 16c741f 📍 **remove redundant dependencies and weeds** # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
KtorZ
force-pushed
the
KtorZ/cardano-address-command-reuse
branch
from
8c9aa28 to
375c77d
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 22, 2020
1780: re-use optparse applicative definitions from cardano-addresses r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 996bc32 📍 **bump cardano-addresses revision in stack.yaml** To include most recent changes and in particular, the revised command-line for addresses and key derivation. - 4d4c1a8 📍 **re-use 'key' and 'recovery-phrase' commands from cardano-addresses** cardano-addresses also has some great extensive tests for these commands, which means that a lot of tests and code in cardano-wallet is now redundant. So I removed them. - 16c741f 📍 **remove redundant dependencies and weeds** # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
…f rollbacks That is a necessary evil until we do have a proper transaction scheduler
|
bors try |
tryBuild succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
N/A
Overview
996bc32
📍 bump cardano-addresses revision in stack.yaml
To include most recent changes and in particular, the revised command-line for addresses
and key derivation.
4d4c1a8
📍 re-use 'key' and 'recovery-phrase' commands from cardano-addresses
cardano-addresses also has some great extensive tests for these commands, which means that a lot of tests
and code in cardano-wallet is now redundant. So I removed them.
16c741f
📍 remove redundant dependencies and weeds
Comments