Allow listing pools based on stake instead of wallet id #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/ADP-311/coin-param-in-list-pools
branch
2 times, most recently
from
bb348b5 to
e7618d6
Compare
Anviking
commented
Jun 17, 2020
| r <- request @[ApiStakePool] ctx (Link.listStakePools (ApiT invalidWalletId, ())) Default Empty | ||
| expectResponseCode HTTP.status404 r | ||
| it "STAKE_POOLS_LIST_05 - Fails without query parameter" $ \ctx -> do | ||
| _w <- fixtureWallet ctx -- Ambiguous type error without this line |
|
bors try |
KtorZ
reviewed
Jun 17, 2020
| | isValidCoin x = | ||
| return x | ||
| | otherwise = | ||
| Left $ TextDecodingError "Coin value is out of bounds" |
There was a problem hiding this comment.
Ho, we didn't get rid of that yet 🤔
KtorZ
reviewed
Jun 17, 2020
| description: | | ||
| The stake the user intends to delegate in Lovelace. Required. | ||
|
|
||
| > ⚠️ On the incentivized testnet, this parameter is not requred, but rather completely ignored. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
1775: Allow listing pools based on stake instead of wallet id r=KtorZ a=Anviking # Issue Number #1720 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Make list stake pool endpoint take `Coin` instead of `WalletId`. - [x] Adjust corresponding types and tests (A few more I think) - [x] Fail with `err400` when query param is not present on Shelley. - [x] Adjust swagger # Comments ``` Originally: GET /stake-pools What was recently introduced: GET /wallets/:wid/stake-pools Now: GET /stake-pools?stake=1000 For jormungandr the query parameter is not required, and unused. This minimises breaking changes. ``` - [Slack thread](https://input-output-rnd.slack.com/archives/C819S481Y/p1592322972378700) - This PR gives greater flexibility to Daedalus and other API users <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
tryBuild failed |
Build failed |
Originally: GET /stake-pools What was recently introduced: GET /wallets/:wid/stake-pools Now: GET /stake-pools?stake=1000 For jormungandr the query parameter is not required, and unused. This minimises breaking changes.
Anviking
force-pushed
the
anviking/ADP-311/coin-param-in-list-pools
branch
from
e7618d6 to
272c52c
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
1775: Allow listing pools based on stake instead of wallet id r=Anviking a=Anviking # Issue Number #1720 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Make list stake pool endpoint take `Coin` instead of `WalletId`. - [x] Adjust corresponding types and tests (A few more I think) - [x] Fail with `err400` when query param is not present on Shelley. - [x] Adjust swagger # Comments ``` Originally: GET /stake-pools What was recently introduced: GET /wallets/:wid/stake-pools Now: GET /stake-pools?stake=1000 For jormungandr the query parameter is not required, and unused. This minimises breaking changes. ``` - [Slack thread](https://input-output-rnd.slack.com/archives/C819S481Y/p1592322972378700) - This PR gives greater flexibility to Daedalus and other API users <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
Timed out |
|
bors try |
tryBuild succeeded |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1720
Overview
Coininstead ofWalletId.err400when query param is not present on Shelley.Comments