Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More integration test cluster logging improvements #1772

Merged
merged 7 commits into from
Jun 22, 2020
Merged

More integration test cluster logging improvements #1772

merged 7 commits into from
Jun 22, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jun 17, 2020 •
edited
Loading

Issue Number

ADP-302 / #1750

Overview

  • Output Debug-severity log files for each cardano-node process to the temporary directory, while only showing Error-severity logs on stdout.
  • Show different hostnames in cardano-node logs so that it's possible to see which node produced the log message.
  • Add a new helper function for starting the cardano-node process.
  • Use a single temp directory for all nodes in the cluster - makes inspecting configs and logs easier.
  • The environment variable NO_CLEANUP causes the integration tests to not delete the temp directory after they have finished.
  • The environment variable CARDANO_NODE_TRACING_MIN_SEVERITY sets the log level the the cluster nodes for stdout.
  • The environment variable CARDANO_WALLET_TRACING_MIN_SEVERITY sets the log level for the wallet server.
  • Also bumps cardano-node and libraries to latest master (to get latest logging features).

@rvl rvl self-assigned this Jun 17, 2020
@rvl rvl force-pushed the rvl/integration-tests-tracing branch from 8849f8c to 2901e16 Compare June 17, 2020 10:07
@rvl rvl force-pushed the rvl/integration-tests-log-files branch from 8f18f39 to e9d8ce6 Compare June 18, 2020 06:21
@rvl rvl marked this pull request as ready for review June 18, 2020 06:24
@KtorZ KtorZ added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Jun 18, 2020
@KtorZ KtorZ force-pushed the rvl/integration-tests-tracing branch from afcff17 to 6f31485 Compare June 19, 2020 11:29
Base automatically changed from rvl/integration-tests-tracing to master June 19, 2020 14:07
@rvl rvl force-pushed the rvl/integration-tests-log-files branch 2 times, most recently from c87eb54 to c4a322d Compare June 22, 2020 07:23
@rvl rvl force-pushed the rvl/integration-tests-log-files branch from 03846f3 to 5c0c840 Compare June 22, 2020 07:48
@rvl
Copy link
Contributor Author

rvl commented Jun 22, 2020

This is rebased and ready for review.

KtorZ
KtorZ approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/shelley/src/Cardano/Wallet/Shelley/Launch.hs
, nodeVrfKeyFile = Just vrfPrv
, nodePort = Just (NodePort port)
, nodeLoggingHostname = Just name
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KtorZ
Copy link
Member

KtorZ commented Jun 22, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 22, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 465657e into master Jun 22, 2020
@iohk-bors iohk-bors bot deleted the rvl/integration-tests-log-files branch June 22, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@rvl rvl

Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-302) Check reward account balance
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @KtorZ