Remove redundant integration test jobs on hydra #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded |
KtorZ
reviewed
Jun 12, 2020
rvl
force-pushed
the
rvl/hydra-integration-test-jobs
branch
4 times, most recently
from
4660da0 to
078ef25
Compare
|
bors try |
tryBuild failed |
rvl
force-pushed
the
rvl/hydra-integration-test-jobs
branch
3 times, most recently
from
78a78ef to
0227a20
Compare
|
bors try |
tryBuild failed |
We don't need to run integration tests for both linux glibc and musl. Choose musl, because that's what our release binaries are. And remove the windows cardano-node integration test jobs, because ouroboros-network doesn't fully work under Wine.
rvl
force-pushed
the
rvl/hydra-integration-test-jobs
branch
from
0227a20 to
74aa8be
Compare
|
bors try |
tryBuild succeeded |
KtorZ
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove redundant integration test jobs on hydra
We don't need to run integration tests for both linux glibc and musl. Choose musl, because that's what our release binaries are.
And remove the windows cardano-node integration test jobs, because ouroboros-network doesn't fully work under Wine.
And while we're here, update Haskell.nix and iohk-nix, and fix resulting errors.⇒ #1791Comments
nix/haskell.nixdid not work because the jobset evaluator is always a linux system. The job filtering needs to be done inrelease.nix.