Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegation fee shelley #1747

Merged
merged 5 commits into from
Jun 12, 2020
Merged

Delegation fee shelley #1747

merged 5 commits into from
Jun 12, 2020

Conversation

paweljakubas
Copy link
Contributor

@paweljakubas paweljakubas commented Jun 12, 2020 •
edited
Loading

Issue Number

#1709

Overview

  • I have enabled delegation fee in Shelley server
  • I have ported integration tests from jormungandr
  • I have adjusted feeMin

Comments

@paweljakubas paweljakubas self-assigned this Jun 12, 2020
@paweljakubas paweljakubas requested review from KtorZ, Anviking and rvl June 12, 2020 10:38
@paweljakubas paweljakubas force-pushed the paweljakubas/1709/delegation-fee-shelley branch from 44a2cd1 to 419f076 Compare June 12, 2020 10:41
rvl
rvl approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@KtorZ
Copy link
Member

KtorZ commented Jun 12, 2020

@paweljakubas I don't think we can have such assertions with cardano-node and the way we do fee estimations there. What we can say however is that real fee should be at most what the minimumFee from our estimator return.

@KtorZ KtorZ added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Jun 12, 2020
@paweljakubas
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 12, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 2787bbd into master Jun 12, 2020
@iohk-bors iohk-bors bot deleted the paweljakubas/1709/delegation-fee-shelley branch June 12, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

@KtorZ KtorZ Awaiting requested review from KtorZ

@Anviking Anviking Awaiting requested review from Anviking

Assignees

@paweljakubas paweljakubas

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-157) implement join/quitStakePoo...
Development

Successfully merging this pull request may close these issues.
3 participants
@paweljakubas @KtorZ @rvl