encode shelley addresses with their final encoding (bech32 / base58) #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
added
the
Feature
Anviking
approved these changes
Jun 13, 2020
| _decodeAddress x = validateWithLedger =<< W.Address <$> fromHex x | ||
| _encodeAddress :: W.Address -> Text | ||
| _encodeAddress (W.Address bytes) = | ||
| if isJust (CBOR.deserialiseCbor CBOR.decodeAddressPayload bytes) |
There was a problem hiding this comment.
A golden here would be nice; I don't think a mistake here would be caught
There was a problem hiding this comment.
I agree. I intended to add some tests, hence the draft 👍
Still, I kept support for base16 when decoding addresses, so that we don't necessarily break compatibility with cardano-cli.
KtorZ
force-pushed
the
KtorZ/shelley-address-encoding
branch
from
443d15b to
09e3fa1
Compare
|
bors try |
tryBuild failed |
Not matching the one the server is started with
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
N/A
Overview
Still, I kept support for base16 when decoding addresses, so that we don't necessarily break compatibility with cardano-cli.
Comments