Add unit test to check updates of decentralizationLevel #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
KtorZ
reviewed
Jun 12, 2020
| -- | A value that is not the same as what's in the test data genesis. | ||
| halfD :: DecentralizationLevel | ||
| halfD = DecentralizationLevel p | ||
| where Right p = mkPercentage (1/2) |
There was a problem hiding this comment.
It is sort of weird to have this unit test in the byron package; the decentralization level is something that exists only in Shelley.
There was a problem hiding this comment.
OK I moved it to the shelley package.
KtorZ
reviewed
Jun 12, 2020
| @@ -6,7 +6,7 @@ protocolParams: | |||
| protocolVersion: | |||
| minor: 0 | |||
| major: 0 | |||
| decentralisationParam: 1 | |||
| decentralisationParam: 1 # means 0% decentralised | |||
There was a problem hiding this comment.
Weird that github shows this diff, whereas master decentralisationParam is actually 0.25 🤔
There was a problem hiding this comment.
Well github doesn't show merge conflicts. It can only show a diff to the merge base.
rvl
force-pushed
the
rvl/1693/d-param-test-case
branch
2 times, most recently
from
734dd56 to
84528b0
Compare
rvl
force-pushed
the
rvl/1693/d-param-test-case
branch
from
84528b0 to
92bf608
Compare
|
bors r- |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 12, 2020
1736: Add unit test to check updates of decentralizationLevel r=KtorZ a=rvl ### Issue Number #1693 can be moved to "QA" column once this is merged. ### Overview - Enhances the "unit test" to check that protocol parameters can be updated to include decentralization level. - Removes "todo" comment from `NETWORK_PARAMS - Able to fetch network parameters` integration test case. The `decentralisationParam` in the shelley integration test genesis is 1.0 ⇒ 0% decentralised. Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: KtorZ <[email protected]>
Build failed |
Ho. We need to provision unit tests with |
|
bors r+ |
KtorZ
added
the
IMPROVEMENT
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1693 can be moved to "QA" column once this is merged.
Overview
NETWORK_PARAMS - Able to fetch network parametersintegration test case. ThedecentralisationParamin the shelley integration test genesis is 1.0 ⇒ 0% decentralised.