Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistakes in .travis.yml deployment preventing shelley binaries from being deployed #1729

Merged
merged 5 commits into from
Jun 8, 2020

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Jun 5, 2020

Issue Number

For v2020-06-05 release.

Overview

  • Rename cardano-wallet to cardano-wallet-byron
  • Make sure shelley binaries are called cardano-wallet-shelley, and remember to add the output to the files list

Comments

Should work now:

Skärmavbild 2020-06-08 kl  15 50 21

@Anviking Anviking requested a review from KtorZ June 5, 2020 16:26
@KtorZ
Copy link
Member

KtorZ commented Jun 7, 2020

hmm. That is the timeout of the cache (2h is a little excessive... 37 minutes was already excessive, but since we're uploading ~1Go of cache the default of 3min was too small); the job are limited to 50 minutes max and there's no way around that on the free-tier. The travis "pro" version allows jobs up 2h but we don't have that here.

@Anviking
Copy link
Member Author

Anviking commented Jun 8, 2020

Btw, I can't have been in my right mind when converting 1337 s, because it is ≈22 minutes, not 37 😅

the job are limited to 50 minutes

I've set it to 40 min / 2400 s now.

@Anviking
Copy link
Member Author

Anviking commented Jun 8, 2020

Although it seems the job already ran for 50 min 🤔 https://travis-ci.org/github/input-output-hk/cardano-wallet/jobs/695076828

@Anviking Anviking self-assigned this Jun 8, 2020
@Anviking Anviking force-pushed the anviking/increase-travis-timeout branch from 8e1012a to a1a74a7 Compare June 8, 2020 13:42
@Anviking Anviking changed the title Increase timeout in travis deployment Fix mistakes in .travis.yml deployment preventing shelley binaries to be deployed Jun 8, 2020
@Anviking Anviking changed the title Fix mistakes in .travis.yml deployment preventing shelley binaries to be deployed Fix mistakes in .travis.yml deployment preventing shelley binaries from being deployed Jun 8, 2020
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo what we discussed on Slack.

@Anviking
Copy link
Member Author

Anviking commented Jun 8, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 8, 2020

@iohk-bors iohk-bors bot merged commit 9f46b23 into master Jun 8, 2020
@iohk-bors iohk-bors bot deleted the anviking/increase-travis-timeout branch June 8, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants