Join stake pool shelley #1722

paweljakubas · 2020-06-03T14:17:50Z

Issue Number

Overview

I have mocked stake pool layer and added joinStakePool to shelley api server
I have added first tests (now wallet id and no pool id) for stake pools in shelley
I have added impl for mkDelegationJoinTx
I have extended mkDelegationJoinTx by adding WalletDelegation
I have added tests for joining/rejoining
I have impl quitting and added tests

Comments

paweljakubas · 2020-06-03T18:05:29Z

I need to still improve on mkDelegationJoinTx as I have :

        from the following response: Left (DecodeFailure "{\"code\":\"created_invalid_transaction\",\"message\":\"That's embarrassing. It looks like I've created an invalid transaction that could not be parsed by the node. Here's an error message that may help with debugging: ApplyTxError [LedgerFailure (DelegsFailure (DelegateeNotRegisteredDELEG (KeyHash 89eb0d6a8a691dae2cd15ed0369931ce0a949ecafa5c3f93f8121833646e15c3))),LedgerFailure (UtxowFailure (UtxoFailure (FeeTooSmallUTxO (Coin 143200) (Coin 122500))))]\"}")

paweljakubas · 2020-06-03T19:45:18Z

lib/shelley/src/Cardano/Wallet/Shelley/Transaction.hs

+            (k, pwd) <- lookupPrivateKey keyFrom addr
+            pure $ mkWitness unsigned (getRawKey k, pwd)
+
+        witsForChimeric <- fmap Set.fromList (pure $ [mkWitness unsigned (getRawKey accXPrv, pwd')])


this is probably the culprit for too low fee - I am adding this artificially

Anviking · 2020-06-10T10:20:01Z

lib/shelley/src/Cardano/Wallet/Shelley/Transaction.hs

+        -> [TxOut]
+        -> Either ErrMkTx (Tx, SealedTx)
+    _mkDelegationJoinTx poolId (accXPrv, pwd') keyFrom slot ownedIns outs = do
+        let timeToLive = (toSlotNo epochLength slot) + 7200


I know this is still a draft, but I hope the similarities between mkDelegationJoinTx and mkStdTx can be factored out

yes, some code overlap - I will reuse it later

KtorZ · 2020-06-10T12:18:22Z

lib/shelley/src/Cardano/Wallet/Shelley/Transaction.hs

+                VerKeyEd25519DSIGN .
+                throwCryptoError $
+                Ed25519.publicKey pId
+                --}


I'd definitely factor these functions out to make the body of this function more readable 👍

KtorZ · 2020-06-10T12:20:22Z

lib/shelley/src/Cardano/Wallet/Shelley/Transaction.hs

+                :: PoolId
+                -> Cardano.ShelleyVerificationKeyHashStakePool
+            toPoolIdHash (PoolId pId) =
+                SL.KeyHash $ Hash.UnsafeHash pId


Shouldn't our pool id be already the hashed version?

right now it is hashed, so it goes wrapped with ledger data constructors. Below, there is version that hashes verification key. But because knownStakePools will return hashes we are not going to use it

KtorZ · 2020-06-10T12:24:13Z

lib/shelley/src/Cardano/Wallet/Shelley/Transaction.hs

+                (toStakingKeyHash accXPrv)
+                (toPoolIdHash poolId)
+        let unsigned =
+                mkUnsignedTx timeToLive ownedIns outs [registerCert, delegateCert]


lib/shelley/src/Cardano/Wallet/Shelley/Transaction.hs

paweljakubas · 2020-06-11T08:24:30Z

bors try

iohk-bors · 2020-06-11T08:46:31Z

try

Build failed

ci/hydra-build:required

…blocks

KtorZ · 2020-06-11T14:48:41Z

bors r+

1722: Join stake pool shelley r=KtorZ a=paweljakubas # Issue Number  #1709 # Overview  - [x] I have mocked stake pool layer and added joinStakePool to shelley api server - [x] I have added first tests (now wallet id and no pool id) for stake pools in shelley - [x] I have added impl for mkDelegationJoinTx - [x] I have extended mkDelegationJoinTx by adding WalletDelegation - [x] I have added tests for joining/rejoining - [x] I have impl quitting and added tests # Comments   Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: KtorZ <[email protected]>

iohk-bors · 2020-06-11T15:49:19Z

Build failed

buildkite/cardano-wallet

KtorZ · 2020-06-11T15:59:23Z

bors r-

KtorZ · 2020-06-11T15:59:33Z

(buildkite failed: https://buildkite.com/input-output-hk/cardano-wallet/builds/8081#512cba9c-4c3b-41ee-b355-34d157978a34)

KtorZ · 2020-06-11T17:08:51Z

bors r+

1722: Join stake pool shelley r=KtorZ a=paweljakubas # Issue Number  #1709 # Overview  - [x] I have mocked stake pool layer and added joinStakePool to shelley api server - [x] I have added first tests (now wallet id and no pool id) for stake pools in shelley - [x] I have added impl for mkDelegationJoinTx - [x] I have extended mkDelegationJoinTx by adding WalletDelegation - [x] I have added tests for joining/rejoining - [x] I have impl quitting and added tests # Comments   Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: KtorZ <[email protected]>

iohk-bors · 2020-06-11T17:33:11Z

Build failed

buildkite/cardano-wallet

KtorZ · 2020-06-11T17:47:16Z

bors r+

1722: Join stake pool shelley r=KtorZ a=paweljakubas # Issue Number  #1709 # Overview  - [x] I have mocked stake pool layer and added joinStakePool to shelley api server - [x] I have added first tests (now wallet id and no pool id) for stake pools in shelley - [x] I have added impl for mkDelegationJoinTx - [x] I have extended mkDelegationJoinTx by adding WalletDelegation - [x] I have added tests for joining/rejoining - [x] I have impl quitting and added tests # Comments   Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: KtorZ <[email protected]>

iohk-bors · 2020-06-11T18:35:10Z

Build failed

ci/hydra-build:required

…leader)

KtorZ · 2020-06-12T06:56:19Z

bors try

The transaction submission command seems to occasionally fail on macos, unable to open the socket.

iohk-bors · 2020-06-12T07:12:42Z

try

Build failed

ci/hydra-build:required

rvl · 2020-06-12T07:29:28Z

Retrying submitTx worked when testing locally...

bors try

iohk-bors · 2020-06-12T07:52:38Z

try

Build failed

buildkite/cardano-wallet

Most messages from the node are actually redundant with the messages we get from our own networking layer.

Pools are still registered on-chain beforehand, so we can still get to test a bunch of things.

KtorZ · 2020-06-12T10:03:22Z

bors r+

iohk-bors · 2020-06-12T10:31:56Z

Build succeeded

paweljakubas added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Jun 3, 2020

paweljakubas added this to the (ADP-157) implement join/quitStakePool in Shelley milestone Jun 3, 2020

paweljakubas self-assigned this Jun 3, 2020

paweljakubas changed the title ~~Paweljakubas/1709/join stake pool shelley~~ Join stake pool shelley Jun 3, 2020

paweljakubas force-pushed the paweljakubas/1709/join-stake-pool-shelley branch 2 times, most recently from 66ef978 to bba630e Compare June 3, 2020 18:03

paweljakubas force-pushed the paweljakubas/1709/join-stake-pool-shelley branch from bba630e to 5791948 Compare June 3, 2020 19:27

paweljakubas commented Jun 3, 2020

View reviewed changes

paweljakubas force-pushed the paweljakubas/1709/join-stake-pool-shelley branch 2 times, most recently from eaf01ae to 8c8d70e Compare June 8, 2020 12:07

Anviking reviewed Jun 10, 2020

View reviewed changes

KtorZ reviewed Jun 10, 2020

View reviewed changes

lib/shelley/src/Cardano/Wallet/Shelley/Transaction.hs Show resolved Hide resolved

KtorZ force-pushed the paweljakubas/1709/join-stake-pool-shelley branch from c43e8ef to cda3f3c Compare June 10, 2020 15:10

paweljakubas force-pushed the paweljakubas/1709/join-stake-pool-shelley branch from 88ce777 to 9841048 Compare June 10, 2020 16:26

paweljakubas marked this pull request as ready for review June 10, 2020 18:24

paweljakubas force-pushed the paweljakubas/1709/join-stake-pool-shelley branch from 9c82939 to d4d3c04 Compare June 11, 2020 08:23

iohk-bors bot added a commit that referenced this pull request Jun 11, 2020

Try #1722:

177e3f7

paweljakubas requested review from Anviking and KtorZ June 11, 2020 08:25

paweljakubas force-pushed the paweljakubas/1709/join-stake-pool-shelley branch from 3033671 to e3b889c Compare June 11, 2020 13:14

paweljakubas and others added 4 commits June 11, 2020 15:50

add joinStakePool to Server and mock StakePoolLayer

f22f612

add StakePools integration suite

e1b93d8

mkDelegationJoinTx - first version

41d4a0f

extract delegation certificates from transaction body when receiving …

cb2b530

…blocks

minor neatpicks while reviewing code.

a719a4c

KtorZ force-pushed the paweljakubas/1709/join-stake-pool-shelley branch from 98c69a3 to a719a4c Compare June 11, 2020 14:48

remove redundant steps in last stake pool integration scenario

1e1c185

KtorZ force-pushed the paweljakubas/1709/join-stake-pool-shelley branch from 771de62 to c8ee7f2 Compare June 11, 2020 17:47

reduce k parameter in genesis and increase d (more blocks by the BFT …

b5d966e

…leader)

KtorZ force-pushed the paweljakubas/1709/join-stake-pool-shelley branch from c8ee7f2 to b5d966e Compare June 12, 2020 06:56

iohk-bors bot added a commit that referenced this pull request Jun 12, 2020

Try #1722:

3a55abf

Retry stake pool registrations in integration tests

003afda

The transaction submission command seems to occasionally fail on macos, unable to open the socket.

iohk-bors bot added a commit that referenced this pull request Jun 12, 2020

Try #1722:

88ad9ac

KtorZ added 2 commits June 12, 2020 11:38

set default shelley cluster severity to Error

d610d60

Most messages from the node are actually redundant with the messages we get from our own networking layer.

hopefully temporary disable running pools in the integration cluster

568a77f

Pools are still registered on-chain beforehand, so we can still get to test a bunch of things.

iohk-bors bot merged commit 5417c0a into master Jun 12, 2020

iohk-bors bot deleted the paweljakubas/1709/join-stake-pool-shelley branch June 12, 2020 10:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Join stake pool shelley #1722

Join stake pool shelley #1722

paweljakubas commented Jun 3, 2020 •

edited

Loading

paweljakubas commented Jun 3, 2020 •

edited

Loading

paweljakubas Jun 3, 2020

Anviking Jun 10, 2020

paweljakubas Jun 10, 2020

KtorZ Jun 10, 2020

KtorZ Jun 10, 2020

paweljakubas Jun 10, 2020

KtorZ Jun 10, 2020

paweljakubas commented Jun 11, 2020

iohk-bors bot commented Jun 11, 2020

KtorZ commented Jun 11, 2020

iohk-bors bot commented Jun 11, 2020

KtorZ commented Jun 11, 2020

KtorZ commented Jun 11, 2020

KtorZ commented Jun 11, 2020

iohk-bors bot commented Jun 11, 2020

KtorZ commented Jun 11, 2020

iohk-bors bot commented Jun 11, 2020

KtorZ commented Jun 12, 2020

iohk-bors bot commented Jun 12, 2020

rvl commented Jun 12, 2020

iohk-bors bot commented Jun 12, 2020

KtorZ commented Jun 12, 2020

iohk-bors bot commented Jun 12, 2020

Join stake pool shelley #1722

Join stake pool shelley #1722

Conversation

paweljakubas commented Jun 3, 2020 • edited Loading

Issue Number

Overview

Comments

paweljakubas commented Jun 3, 2020 • edited Loading

paweljakubas Jun 3, 2020

Choose a reason for hiding this comment

Anviking Jun 10, 2020

Choose a reason for hiding this comment

paweljakubas Jun 10, 2020

Choose a reason for hiding this comment

KtorZ Jun 10, 2020

Choose a reason for hiding this comment

KtorZ Jun 10, 2020

Choose a reason for hiding this comment

paweljakubas Jun 10, 2020

Choose a reason for hiding this comment

KtorZ Jun 10, 2020

Choose a reason for hiding this comment

paweljakubas commented Jun 11, 2020

iohk-bors bot commented Jun 11, 2020

try

Build failed

KtorZ commented Jun 11, 2020

iohk-bors bot commented Jun 11, 2020

Build failed

KtorZ commented Jun 11, 2020

KtorZ commented Jun 11, 2020

KtorZ commented Jun 11, 2020

iohk-bors bot commented Jun 11, 2020

Build failed

KtorZ commented Jun 11, 2020

iohk-bors bot commented Jun 11, 2020

Build failed

KtorZ commented Jun 12, 2020

iohk-bors bot commented Jun 12, 2020

try

Build failed

rvl commented Jun 12, 2020

iohk-bors bot commented Jun 12, 2020

try

Build failed

KtorZ commented Jun 12, 2020

iohk-bors bot commented Jun 12, 2020

Build succeeded

paweljakubas commented Jun 3, 2020 •

edited

Loading

paweljakubas commented Jun 3, 2020 •

edited

Loading