Enable restoration of Byron Sequential wallet from xpub #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
reviewed
Jun 3, 2020
| let state = mkSeqStateFromAccountXPub (liftKey accXPub) g | ||
| void $ liftHandler $ initWorker @_ @s @k ctx wid | ||
| (\wrk -> W.createWallet @(WorkerCtx ctx) @s @k wrk wid wName state) | ||
| (\wrk -> W.restoreWallet @(WorkerCtx ctx) @s @t @k wrk wid) | ||
| fst <$> getWallet ctx (mkShelleyWallet @_ @s @t @k) (ApiT wid) | ||
| fst <$> getWallet ctx mkWallet (ApiT wid) |
paweljakubas
approved these changes
Jun 3, 2020
paweljakubas
reviewed
Jun 3, 2020
specifications/api/index.html
Outdated
| * | ||
| * TODO: Make this configurable upstream in ReDoc. | ||
| */ | ||
| window.onload = function () { |
KtorZ
force-pushed
the
KtorZ/ADP-334/byron-restoration-from-xpub
branch
from
3faf902 to
030d624
Compare
|
bors try |
tryBuild failed |
KtorZ
force-pushed
the
KtorZ/ADP-334/byron-restoration-from-xpub
branch
from
030d624 to
7e31610
Compare
Instead of mere 'object', they now have significant names
Instead of showing the import from account public key as default
KtorZ
force-pushed
the
KtorZ/ADP-334/byron-restoration-from-xpub
branch
from
9dce4c7 to
08bfe99
Compare
|
bors try |
|
❤️ |
tryBuild failed |
|
WHAT IS YOUR PROBLEM HYDRA FFS |
|
bors try |
|
@disassembler there's also a failure in the test suite that needs resolution first. |
tryBuild failed |
|
bors try |
tryBuild failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-334
Overview
3ef0e95
📍 extend swagger specification to add xpub restoration for byron sequential wallets
5deb64c
📍 extend swagger specification to add xpub restoration for byron sequential wallets
7cc16c1
📍 quick-n-dirty hack of the documentation to explicitely name oneof labels
Instead of mere 'object', they now have significant names
69257ad
📍 show 'standard' wallet as default in API documentation for shelley
Instead of showing the import from account public key as default
58ab322
📍 extend Byron servant API to allow restoring Byrons sequential wallet from xpub
bd8c008
📍 generalize a bit some DSL function to work with both Byron & Shelley wallets
d69de74
📍 fix JSON parsers for posting Byron wallets: there's a new case
0ef9a31
📍 wire hardware wallet integration tests with cardano-node-byron
773ad3a
📍 remove hack in favor and use schema 'title' property instead
c3b2273
📍 extend API specification to support coin selection for byron wallets
08bfe99
📍 turn on coin selection endpoint for byron wallets in byron & shelley servers
Comments