Revise documentation for NetworkParameters and related types.
#1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Network Parameters" represents the complete set of parameters that are currently in use by the network. This set includes parameters defined by the genesis block and also protocol parameters that can be updated through the update system.
In response to review feedback: #1715 (comment)
In response to review feedback: #1715 (comment)
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 3, 2020
1715: Revise documentation for `NetworkParameters` and related types. r=jonathanknowles a=jonathanknowles # Related Issues #1693 # Overview PR #1700 changed the way that network parameters are defined. This PR revises and adds documentation for the following types: - [x] `NetworkParameters` - [x] `GenesisParameters` - [x] `ProtocolParameters` - [x] `TxParameters` Co-authored-by: Jonathan Knowles <[email protected]>
rvl
approved these changes
Jun 3, 2020
Build failed |
Point out that this type only includes parameters that are relevant to the wallet. In response to review feedback: #1715 (comment)
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 3, 2020
1715: Revise documentation for `NetworkParameters` and related types. r=jonathanknowles a=jonathanknowles # Related Issues #1693 # Overview PR #1700 changed the way that network parameters are defined. This PR revises and adds documentation for the following types: - [x] `NetworkParameters` - [x] `GenesisParameters` - [x] `ProtocolParameters` - [x] `TxParameters` Co-authored-by: Jonathan Knowles <[email protected]>
Build failed |
|
bors r+ |
|
The PR #1716 should fix those |
Build succeeded |
14 tasks
KtorZ
added
the
ADDING FEATURE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#1693
Overview
PR #1700 changed the way that network parameters are defined.
This PR revises and adds documentation for the following types:
NetworkParametersGenesisParametersProtocolParametersTxParameters