assign default encryption scheme for passphrase with none. #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
approved these changes
Jun 2, 2020
This is cleaner than doing some add-hoc transformation when the wallet gets read from the database. And, it allows for some unit testing to happen!
KtorZ
commented
Jun 2, 2020
| @@ -378,6 +414,7 @@ migrateManually tr defaultFieldValues = | |||
| _ <- Sqlite.step addColumn | |||
| Sqlite.finalize addColumn | |||
| where | |||
| activeSlotCoeff = DBField CheckpointActiveSlotCoeff | |||
KtorZ
commented
Jun 2, 2020
| @@ -353,6 +388,7 @@ migrateManually tr defaultFieldValues = | |||
| Sqlite.finalize stmt | |||
| where | |||
| hardLowerBound = toText $ fromEnum $ minBound @(Index 'Hardened _) | |||
| rndAccountIx = DBField RndStateAddressAccountIndex | |||
…rking as intended
KtorZ
force-pushed
the
KtorZ/1701/passphrase-scheme-fix
branch
from
5762d5a to
05b6fd7
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 2, 2020
1704: assign default encryption scheme for passphrase with none. r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1701 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - a4dd767 📍 **assign default encryption scheme for passphrase with none.** # Comments <!-- Additional comments or screenshots to attach if any --> cc @nikolaglumac <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
|
bors retry |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 2, 2020
1704: assign default encryption scheme for passphrase with none. r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1701 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - a4dd767 📍 **assign default encryption scheme for passphrase with none.** # Comments <!-- Additional comments or screenshots to attach if any --> cc @nikolaglumac <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build failed |
KtorZ
added
the
RESOLVING ISSUE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1701
Overview
📍 assign default encryption scheme for passphrase with none.
Comments
cc @nikolaglumac