Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Fix input resolution when number of inputs is large #1696

Merged
merged 1 commit into from
May 27, 2020
Merged

sql: Fix input resolution when number of inputs is large #1696

merged 1 commit into from
May 27, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented May 27, 2020 •
edited
Loading

Issue Number

#1670 / #1685

Overview

The "too many SQL variables" problem strikes again in the nightly benchmark.

One way to fix it is to do a SQL join or subquery.

Another way to fix it (this PR) is to make the select query in chunks.

Comments

Tested with:

cabal run cardano-wallet-core:bench:db  -- --match prefix "TxHistory (Read)/1000"

or

stack bench cardano-wallet-core:bench:db --ba '--match prefix "TxHistory (Read)/1000"'

@rvl rvl self-assigned this May 27, 2020
@rvl
sql: Fix input resolution when number of inputs is large
6f3f6bc 
The "too many SQL variables" problem strikes again.

One way to fix it is to do a SQL join or subquery.

Another way to fix it is to make the select query in chunks.
KtorZ
KtorZ approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rvl rvl marked this pull request as ready for review May 27, 2020 07:20
@rvl rvl force-pushed the rvl/1670/fix-db-subquery branch from 90ceafa to 6f3f6bc Compare May 27, 2020 08:15
@KtorZ
Copy link
Member

KtorZ commented May 27, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 27, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 8b10273 into master May 27, 2020
@iohk-bors iohk-bors bot deleted the rvl/1670/fix-db-subquery branch May 27, 2020 20:01
@KtorZ KtorZ added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@rvl rvl

Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @KtorZ