Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shelley mainnet and testnet to nightly restore tests #1695

Merged
merged 18 commits into from
Aug 5, 2020
Merged

Add shelley mainnet and testnet to nightly restore tests #1695

merged 18 commits into from
Aug 5, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented May 27, 2020 •
edited
Loading

Issue Number

ADP-356 / #1919

Overview

  • Ports restore benchmark to shelley backend, using cardano-mode mainnet and testnet networks.
  • Add option handling to restore benchmark instead of using environment variables.
  • Change restore benchmark to use cardano-node configuration in such a way that it can easily be run without the assistance of nix.

Comments

  • CLI usage below.

@rvl rvl self-assigned this May 27, 2020
@rvl rvl force-pushed the rvl/adp-289/deployment-configs branch from 164623f to 2c6a726 Compare May 27, 2020 23:59
Base automatically changed from rvl/adp-289/deployment-configs to master May 28, 2020 05:35
@rvl rvl force-pushed the rvl/adp-289/bench-restore-ff branch from eecc372 to a686fea Compare May 29, 2020 13:48
@rvl rvl force-pushed the rvl/adp-289/bench-restore-ff branch from a686fea to 525d0a8 Compare June 9, 2020 13:04
@rvl rvl force-pushed the rvl/adp-289/bench-restore-ff branch 2 times, most recently from e894da4 to 95dcc4e Compare July 3, 2020 14:34
@rvl rvl changed the title wip: Add Shelley ff testnet to nightly restore tests Add shelley_testnet to nightly restore tests Jul 3, 2020
@rvl rvl added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Jul 14, 2020
@rvl rvl force-pushed the rvl/adp-289/bench-restore-ff branch from 95dcc4e to 10e76e6 Compare July 27, 2020 12:46
@rvl rvl changed the title Add shelley_testnet to nightly restore tests Add shelley mainnet and testnet to nightly restore tests Jul 27, 2020
@rvl rvl mentioned this pull request Jul 27, 2020
Closed
9 tasks
@Anviking Anviking force-pushed the rvl/adp-289/bench-restore-ff branch from 4eead16 to d7d8cd7 Compare July 29, 2020 12:39
@Anviking
Copy link
Member

I rebased and made cardano-wallet-shelley:bench:restore compile, but I don't know what arguments to pass it in order to test.

@Anviking Anviking force-pushed the rvl/adp-289/bench-restore-ff branch from d7d8cd7 to 141e8e7 Compare July 29, 2020 12:41
@rvl
Copy link
Contributor Author

rvl commented Jul 30, 2020

Thanks @Anviking. The way you start the benchmark now is this.

  1. Ensure you have configuration files in a directory like so:

    ./configs
├── mainnet
│   ├── configuration.json
│   └── topology.json
└── testnet
    ├── configuration.json
    └── topology.json

  2. Run something like:

    stack run cardano-wallet-shelley:bench:restore -- testnet -c ./configs

    Alternatively, use the $CARDANO_NODE_CONFIGS environment variable coming from nix-shell. (This is the default if -c option is not provided.

  3. If you wish to re-use the node chain data between runs, apply the --node-db option or set the $NODE_DB environment variable.

@rvl rvl marked this pull request as ready for review July 30, 2020 05:59
@Anviking Anviking force-pushed the rvl/adp-289/bench-restore-ff branch 2 times, most recently from 8b64359 to 1bfecb2 Compare July 30, 2020 18:55
@Anviking
Copy link
Member

Not sure why they are not starting here: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/588#_

Anviking
Anviking approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the BenchShared good to have even though we are about to remove the byron component, and only have a shelley restore bench?

LGTM pending that it works.

@rvl
Copy link
Contributor Author

rvl commented Jul 31, 2020 •
edited
Loading

I fixed the buildkite pipeline. Some things needed updating after moving the benchmark to shelley.
The new build will be here: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/595

@rvl rvl force-pushed the rvl/adp-289/bench-restore-ff branch from 5d5c505 to f96a6dc Compare August 4, 2020 05:24
@rvl
Copy link
Contributor Author

rvl commented Aug 5, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 5, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 1b3c537 into master Aug 5, 2020
@iohk-bors iohk-bors bot deleted the rvl/adp-289/bench-restore-ff branch August 5, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

Assignees

@rvl rvl

Labels
IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-356) Integration with Hard Fork ...
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @Anviking