jormungandr: Fix "Blockchain tip not set in REST context" #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jormungandr seems to have changed the HTTP response status code for bootstrap again. This will fix the resulting error, in such a way that if the status code changes back to 503, things will still work. Resolves #1647
6 tasks
|
Nice catch. |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Resolves #1647
Resolves #1649
Overview
Jormungandr seems to have changed the HTTP response status code for bootstrap again. This will fix the resulting error, in such a way that if the status code changes back to 503, things will still work.
Comments
It may be better to poll the
/api/v0/node/stats, but that would be a substantially bigger code change.Tested with: