docker: fix latest tag #1660
Merged
docker: fix latest tag #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rvl
commented
May 14, 2020
rvl
commented
- Only update "inputoutput/cardano-wallet:latest" for tag builds.
- Don't push unique tags for each git revision, because it clutters the repo page on Dockerhub.
- Only update "inputoutput/cardano-wallet:latest" for tag builds. - Don't push unique tags for each git revision, because it clutters the repo page on Dockerhub.
rvl
force-pushed
the
rvl/fix-docker-tagging
branch
from
f12c760 to
d8483ed
Compare
KtorZ
reviewed
May 14, 2020
| echo "Pushing $fullrepo:latest" | ||
| docker tag "$tagged" "$fullrepo:latest" | ||
| docker push "$fullrepo:latest" | ||
| tags+=( "latest" ) |
There was a problem hiding this comment.
This will soon have to change for "shelley" 😛
KtorZ
approved these changes
May 14, 2020
|
bors r+ |
Build succeeded |
KtorZ
added
RESOLVING ISSUE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.