adjust logging output for the NTP client #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turning these:
```
Info] ntp client run protocol results: BothSucceded [NtpOffset {getNtpOffset = Microsecond (-5927)},NtpOffset {getNtpOffset = Microsecond (-5938)},NtpOffset {getNtpOffset = Microsecond (-5460)},NtpOffset {getNtpOffset = Microsecond (-4081)},NtpOffset {getNtpOffset = Microsecond (-5449)},NtpOffset {getNtpOffset = Microsecond (-5300)}]
Info] ntp client gives result of NtpDrift (NtpOffset {getNtpOffset = Microsecond (-5938)})
```
Into:
```
Debug] ntp client run protocol results: -5433μs, 4330μs, -8288μs, -6700μs, -4160μs, -6512μs
Info] local clock is drifting by -8288μs
```
KtorZ
added
the
IMPROVEMENT
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 7, 2020
1636: adjust logging output for the NTP client r=KtorZ a=KtorZ
# Issue Number
<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->
N/A
# Overview
<!-- Detail in a few bullet points the work accomplished in this PR -->
Turning these:
```
Info] ntp client run protocol results: BothSucceded [NtpOffset {getNtpOffset = Microsecond (-5927)},NtpOffset {getNtpOffset = Microsecond (-5938)},NtpOffset {getNtpOffset = Microsecond (-5460)},NtpOffset {getNtpOffset = Microsecond (-4081)},NtpOffset {getNtpOffset = Microsecond (-5449)},NtpOffset {getNtpOffset = Microsecond (-5300)}]
Info] ntp client gives result of NtpDrift (NtpOffset {getNtpOffset = Microsecond (-5938)})
```
Into:
```
Debug] ntp client run protocol results: -5433μs, 4330μs, -8288μs, -6700μs, -4160μs, -6512μs
Info] local clock is drifting by -8288μs
```
# Comments
<!-- Additional comments or screenshots to attach if any -->
The `NtpTraceRunProtocolResults` message is somewhat redundant with `NtpTraceResult` so I downgraded it to "Debug". What's really interesting at the "Info" level is the actual drift offset.
<!--
Don't forget to:
✓ Self-review your changes to make sure nothing unexpected slipped through
✓ Assign yourself to the PR
✓ Assign one or several reviewer(s)
✓ Once created, link this PR to its corresponding ticket
✓ Assign the PR to a corresponding milestone
✓ Acknowledge any changes required to the Wiki
-->
1639: Post v2020-05-06 updates r=piotr-iohk a=piotr-iohk
# Issue Number
https://github.com/input-output-hk/cardano-wallet/wiki/Release-Checklist#publication
# Overview
- 2ed11d1
Update README compat table
- 0c2bab7
Update revisions for migration tests
# Comments
<!-- Additional comments or screenshots to attach if any -->
<!--
Don't forget to:
✓ Self-review your changes to make sure nothing unexpected slipped through
✓ Assign yourself to the PR
✓ Assign one or several reviewer(s)
✓ Once created, link this PR to its corresponding ticket
✓ Assign the PR to a corresponding milestone
✓ Acknowledge any changes required to the Wiki
-->
Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
Build failed (retrying...) |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
N/A
Overview
Turning these:
Into:
Comments
The
NtpTraceRunProtocolResultsmessage is somewhat redundant withNtpTraceResultso I downgraded it to "Debug". What's really interesting at the "Info" level is the actual drift offset.