Reduce logging from network layer #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
added
the
IMPROVEMENT
jonathanknowles
approved these changes
May 7, 2020
| @@ -497,6 +494,11 @@ mkTipSyncClient tr localTxSubmissionQ onTipUpdate onTxParamsUpdate = do | |||
| Right (Right ls) -> | |||
| onTxParamsUpdate' $ txParametersFromUpdateState ls | |||
|
|
|||
| onTipUpdate' <- debounce $ \tip -> do | |||
|
Thanks bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 7, 2020
1630: Reduce logging from network layer r=rvl a=rvl ### Issue Number Relates to #1577 / ADP-83. ### Overview - Set network tip log level to debug - Improve formatting of text log message - Only log the tip when it changes, because the node can seem to send updates when nothing changes ### Comments This is what it looks like now: ``` [cardano-wallet.network:Debug:18] [2020-05-06 07:49:54.10 UTC] Network node tip block height is 4125310 at hash c5cb3bcd ``` 1633: review RELEASE_TEMPLATE to constuct changelog from PR + labels r=rvl a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> We used to organize the CHANGELOG by milestones, but we are now organizing it by 'type of change' (improvement, bug fix, addition). Therefore, the current thing called CHANGELOG is redundant with the other. I've tweaked the 'make_changelog' script to build a changelog according to these categories, provided that PR were labelled accordingly. # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Matthias Benkort <[email protected]> Co-authored-by: KtorZ <[email protected]>
Build failed (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
May 7, 2020
1630: Reduce logging from network layer r=rvl a=rvl ### Issue Number Relates to #1577 / ADP-83. ### Overview - Set network tip log level to debug - Improve formatting of text log message - Only log the tip when it changes, because the node can seem to send updates when nothing changes ### Comments This is what it looks like now: ``` [cardano-wallet.network:Debug:18] [2020-05-06 07:49:54.10 UTC] Network node tip block height is 4125310 at hash c5cb3bcd ``` Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Matthias Benkort <[email protected]>
- Set network tip log level to debug - Improve formatting of text log message - Only log the tip when it changes, because the node can seem to send updates when nothing changes
rvl
force-pushed
the
rvl/adp-83/reduce-network-layer-logging
branch
from
46b07c0 to
b489ca0
Compare
Canceled |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Relates to #1577 / ADP-83.
Overview
Comments
This is what it looks like now: