Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial integration with shelley node #1626

Merged
merged 22 commits into from
May 14, 2020
Merged

Initial integration with shelley node #1626

merged 22 commits into from
May 14, 2020

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented May 5, 2020 •
edited
Loading

Issue Number

ADP-289, #1657

Overview

  • Copied the cardano-wallet-byron structure and made it compile for shelley
  • Completely unimplemented TransactionLayer
  • A few integration tests and unit tests are running (that don't need txs)
  • Add appropriate CLI and API
  • Make sure a wallet can be restored

Comments

@Anviking Anviking force-pushed the anviking/ADP-289/cardano-wallet-shelley branch from 5184116 to 08c8854 Compare May 5, 2020 19:53
@KtorZ
Copy link
Member

KtorZ commented May 6, 2020 •
edited
Loading

@Anviking can you reach out to the networking & consensus team on #ouroboros-network-dev and find out about "Seems local state query is not supported yet since there is no QueryLedger (ShelleyBlock c) instance in ouroboros-network." ?

KtorZ
KtorZ reviewed May 6, 2020
View reviewed changes
lib/shelley/src/Cardano/Wallet/Shelley/Compatibility.hs
SL.bheaderPrev header
}
, transactions = txs
, delegations = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always the case for now or are delegation certificates somewhat already specified in the ShelleyBlock type?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can access them

https://github.com/input-output-hk/cardano-ledger-specs/blob/caa0b377698aace2550d1a9948a050bfa296a3e0/shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/TxData.hs#L315-L328

@Anviking Anviking changed the title Course draft: Initial integration with shelley node Coarse draft: Initial integration with shelley node May 6, 2020
@Anviking Anviking self-assigned this May 6, 2020
@Anviking Anviking force-pushed the anviking/ADP-289/cardano-wallet-shelley branch from 4797940 to 676f3fa Compare May 6, 2020 11:53
@KtorZ KtorZ added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label May 6, 2020
@Anviking Anviking force-pushed the anviking/ADP-289/cardano-wallet-shelley branch 7 times, most recently from 97671dd to 2101c62 Compare May 8, 2020 10:04
@Anviking Anviking force-pushed the anviking/ADP-289/cardano-wallet-shelley branch from deb1ec2 to 77bc8cb Compare May 11, 2020 15:46
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 13, 2020

try

Build failed

@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request May 13, 2020
@iohk-bors
Try #1626:
3e1a7fd
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 13, 2020

try

Build failed

@rvl rvl force-pushed the anviking/ADP-289/cardano-wallet-shelley branch from dd698e1 to 68d0402 Compare May 14, 2020 05:26
@rvl
Copy link
Contributor

rvl commented May 14, 2020

I have updated the version of cardano-node used for Buildkite. With this version, cardano-wallet-shelley:test:integration passes for me locally. I have also added more shelley to the nix.

bors try

iohk-bors bot added a commit that referenced this pull request May 14, 2020
@iohk-bors
Try #1626:
6d41f6b
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 14, 2020

try

Build failed

@rvl
Copy link
Contributor

rvl commented May 14, 2020

In that last bors run the shelley integration tests have passed but not the jormungandr unit tests. There was also a problem with the nix build which I think I have fixed.

@Anviking
Copy link
Member Author

Thanks!

jormungandr unit tests

🤔
bors try

iohk-bors bot added a commit that referenced this pull request May 14, 2020
@iohk-bors
Try #1626:
55e23a1
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 14, 2020

try

Build failed

@Anviking
Copy link
Member Author 

ined reference to `_gcry_mpih_addmul_1'
/nix/store/vcnbgxj6qn1xmawrcsw63vd9bs1vllrc-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: ./.libs/libgcrypt.so: undefined reference to `_gcry_mpih_rshift'
/nix/store/vcnbgxj6qn1xmawrcsw63vd9bs1vllrc-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: ./.libs/libgcrypt.so: undefined reference to `_gcry_mpih_add_n'
/nix/store/vcnbgxj6qn1xmawrcsw63vd9bs1vllrc-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: ./.libs/libgcrypt.so: undefined reference to `_gcry_mpih_mul_1'
/nix/store/vcnbgxj6qn1xmawrcsw63vd9bs1vllrc-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: ./.libs/libgcrypt.so: undefined reference to `_gcry_mpih_submul_1'
/nix/store/vcnbgxj6qn1xmawrcsw63vd9bs1vllrc-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: ./.libs/libgcrypt.so: undefined reference to `_gcry_mpih_lshift'
/nix/store/vcnbgxj6qn1xmawrcsw63vd9bs1vllrc-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: ./.libs/libgcrypt.so: undefined reference to `_gcry_mpih_sub_n'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:728: mpicalc] Error 1
make[2]: Leaving directory '/build/libgcrypt-1.8.5/src'
make[1]: *** [Makefile:497: all-recursive] Error 1
make[1]: Leaving directory '/build/libgcrypt-1.8.5'
make: *** [Makefile:429: all] Error 2
builder for '/nix/store/v3s67c98zmc3jlw9jsryk4yy7hf1vz0k-libgcrypt-1.8.5-x86_64-unknown-linux-musl.drv' failed with exit code 2

@Anviking
Copy link
Member Author

bors r+

@Anviking
Copy link
Member Author

Anviking commented May 14, 2020 •
edited
Loading

bors r-

Seems problems due to timeouts are expected today
https://input-output-rnd.slack.com/archives/CAP8NM7N0/p1589424744022100

Will try again at the end of the day

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 14, 2020

Canceled

@Anviking
Copy link
Member Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 14, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit f36904e into master May 14, 2020
@iohk-bors iohk-bors bot deleted the anviking/ADP-289/cardano-wallet-shelley branch May 14, 2020 14:39
@Anviking Anviking mentioned this pull request May 15, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@Anviking Anviking

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-289) Initial server integration ...
Development

Successfully merging this pull request may close these issues.
4 participants
@Anviking @KtorZ @rvl @disassembler