Skip to content

Commit

Permalink
Remove LoggingSpec in attempt to alleviate timeouts
Browse files Browse the repository at this point in the history
- This might help reduce unit test timeouts.
- They were flaky in the past (in the normal sense), but possibly very occasionally after we
fixed them.
- They shouldn't be /that/ valuable

Investigating #2472 Jonathan found the following tests to fail with limited ulimit -v:
    36% Match String: "Checkpoint"
    44% Match String: "correct time measures"
   100% Match String: "different request ids"
    20% Match String: "Private Key"
    32% Match String: "Tx History"
    28% Match String: "Wallet Metadata"

where entries 2 and 3 are from LogginsSpec.

The timeouts in CI were in these following locations:

They occur in
  12 times (28%) 000000 // from "Not Allowed Methods"
  9 times (21%) Checkpoint
  8 times (19%) rollback
  5 times (12%) 8601 // from e.g. "ISO 8601 extended format without timezones"
  4 times (9%) JSON
  4 times (9%) MVar
  4 times (9%) readStakeDistribution // only in the past, so now fixed
  1 times (2%) Coverage

which either suggest there are an 10+ lines of output left out from the
failures, or the LoggingSpec isn't to blame.

So it would be very interesting to see whether this commit reduces
timeouts or not.
  • Loading branch information
Anviking committed Jun 11, 2021
1 parent 6f67b6b commit c795177
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 461 deletions.
1 change: 0 additions & 1 deletion lib/core/cardano-wallet-core.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ test-suite unit
Data.Time.TextSpec
Data.Time.UtilsSpec
Data.Vector.ShuffleSpec
Network.Wai.Middleware.LoggingSpec
Spec

benchmark db
Expand Down
Loading

0 comments on commit c795177

Please sign in to comment.