-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0100 | Small clean up on example files #736
Conversation
One question; The cips.cardano.org site seems to be broken for CIP-100 see here, so I am tempted to change all references to cips.cardano.org to direct to Github instead. |
@Ryun1 for these links I think consistency is vital, and GitHub has always been a constant (since converting from Whatever revision is done on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So assuming #736 (comment) is satisfactory, everything looks good to me.
@rphair |
It's worth noting that the urls in the context don't actually need to resolve to anything; the computer doesn't recursively fetch those documents. They are effectively just constants that everyone uses for disambiguation. So, I'm fine with updating them now, but even if GitHub changes, it's important to not update them once there is data in the wild. |
(side-note, I am checking why that CIP -- and possibly a few others -- is missing from the new website). |
Also; in the examples I just changed hashing algorithm from blake2b-224 to blake2b-256 as only 256 is the only supported. |
@Ryun1 did you update the resulting hash in the test vector in the readme.md? |
Motivation
Whilst making some more example files, I have found a couple inconsistencies with the provided examples.
Changes
cc @Quantumplation