Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0052 | Adjust preamble and structure w.r.t CIP-0001 #702

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Dec 22, 2023

Fixes #701.

@simonjohnthompson I've had to make some adjustments due to more rigorous formatting requirements and stricter requirements in anticipation of becoming Active since this was originally merged.

The main text shuffle was to move your Appendix into the "Prerequisites" for your Specification. This assumes these terms are essential to implementing the audit process exactly as envisioned in your Specification.

  • If that assumption isn't true, or if the background material is cumbersome in that position, especially if common knowledge to auditors, this might be offloaded to a document like "Handbook for audits" that exists outside the CIP.

I had to delete the "example audit" since its web page is defunct and the Wayback Machine version doesn't run the right code to download the PDF. If you have that document in the raw perhaps it can be linked into the CIP somehow.

Finally I do believe this should have a proper Path to Active since neither auditors nor those who use audit services have provided the CIP repository with examples of CIP-0052 in audits which would qualify this CIP as Active.

  • Hopefully with the qualification of usage that I have added, any auditors following CIP-0052 would be encouraged to submit their audits as evidence of Active status for this CIP.

(updated proposal)

Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rphair rphair requested a review from Crypto2099 January 1, 2024 23:06
Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rphair rphair merged commit 9674efd into cardano-foundation:master Jan 6, 2024
@rphair rphair removed the Remediation label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIP-0052 | Adjust preamble and structure w.r.t CIP-0001
3 participants