Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0009 | Adjust preamble and structure w.r.t CIP-0001 #650

Merged
merged 4 commits into from
Jan 6, 2024
Merged

CIP-0009 | Adjust preamble and structure w.r.t CIP-0001 #650

merged 4 commits into from
Jan 6, 2024

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Dec 20, 2023 •
edited
Loading

Fixes #649.

(edited version)

@rphair
Copy link
Collaborator Author

rphair commented Dec 20, 2023

@kevinhammond N.B. the copyright notice in the header was Creative Commons, while the document footer said Apache. I'm guessing both that the Apache choice was made deliberately and that this was because of the code sections in the document, and that the CC in the header was probably copied indeliberately. FYI I've set both to Apache.

@rphair rphair mentioned this pull request Dec 20, 2023
Closed
@rphair rphair mentioned this pull request Dec 21, 2023
Merged
Ryun1
Ryun1 reviewed Dec 29, 2023
View reviewed changes
Ryun1
Ryun1 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rphair @Ryun1
IOG web site name in header
8385f19 
Co-authored-by: Ryan Williams <[email protected]>
@rphair rphair requested a review from Crypto2099 December 29, 2023 21:26
@rphair rphair mentioned this pull request Jan 1, 2024
Merged
@kevinhammond
Copy link
Contributor

@kevinhammond N.B. the copyright notice in the header was Creative Commons, while the document footer said Apache. I'm guessing both that the Apache choice was made deliberately and that this was because of the code sections in the document, and that the CC in the header was probably copied indeliberately. FYI I've set both to Apache.

Yes Apache is consistent with other IOHK material and should be sufficiently permissive

Crypto2099
Crypto2099 approved these changes Jan 6, 2024
View reviewed changes
Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rphair rphair merged commit 21ba325 into cardano-foundation:master Jan 6, 2024
@rphair rphair removed the Remediation label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryun1 Ryun1 Ryun1 approved these changes

@Crypto2099 Crypto2099 Crypto2099 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CIP-0009 | Adjust preamble and structure w.r.t CIP-0001
4 participants
@rphair @kevinhammond @Ryun1 @Crypto2099