Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Android: Fix guideColor config, fix return of card scan results succe… #44

Closed

Conversation

lolptdr
Copy link
Contributor

@lolptdr lolptdr commented Sep 7, 2016

…ssfully, add permissions and activities for plugin

Fix guideColor config

  • Abstract logic for ensuring hex color string returns as int
  • Default to Color.GREEN if none given

Fix return of card scan results successfully

  • Check if camera scan is canceled first then check card scan results

Add permissions and activities for plugin

  • Add android permissions for VIBRATE and CAMERA
  • Add uses-features for camera hardware
  • Add activity for the io.card.payment.CardIOActivity and io.card.payment.DataEntryActivity classes

…ssfully, add permissions and activities for plugin

Fix guideColor config
* Abstract logic for ensuring hex color string returns as int
* Default to Color.GREEN if none given

Fix return of card scan results successfully
* Check if camera scan is canceled first then check card scan results

Add permissions and activities for plugin
* Add android permissions for VIBRATE and CAMERA
* Add uses-features for camera hardware
* Add activity for the io.card.payment.CardIOActivity and io.card.payment.DataEntryActivity classes
@braebot
Copy link
Member

braebot commented Sep 11, 2016

Thanks for the PR! However, I think it would be best if you do the following:

  1. Split this PR into multiple PRs, one for each group of changes. This would end up being at least 3 PRs, due to the various changes within this one.
  2. Provide a description of why the changes were made, rather than what was changed. Reviewing this PR, I'm unable to determine why the changes are required.

I will close this PR, but will be happy to review and merge other PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants