Closed
Conversation
dwblaikie
approved these changes
Oct 8, 2025
danakj
reviewed
Oct 9, 2025
| // discard the pointer without destroying or deallocating it. | ||
| auto clang_instance = std::make_unique<clang::CompilerInstance>( | ||
| std::move(invocation), std::move(pch_ops)); | ||
| clang_instance->setVirtualFileSystem(fs_); |
Contributor
There was a problem hiding this comment.
nit: Can this go down on L329 (just before createDiagnostics()) to continue making this function match with the one in cc1_main that it's mirroring?
Contributor
Author
There was a problem hiding this comment.
Hmmmm, interesting point, I hadn't been aware this was a copy of LLVM code since there's no separate license notice.
Moving this PR to draft until we can discuss it with @chandlerc
Contributor
|
Some pretty interesting errors in clangd-tidy though... |
Contributor
Author
Yes, I think that's a bug in the action. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
Tested locally in relation to #6182, difficult to test server-side because of the action change combined with the edge-case issue.
Contributor
Author
|
Closing since this overlaps with #6147. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in particular to pick up fixes in llvm/llvm-project#160804 (so that a more recent LLVM compiler can be used with Carbon), but also addresses a few deprecations.