Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ibm products): react 19 createcontext argument support #6218

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sangeethababu9223
Copy link
Member

Closes #5039

createContext requires an argument

What did you change?

Changed createContext() to createContext(undefined)

How did you test and verify your work?

Storybook

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner October 15, 2024 10:24
@sangeethababu9223 sangeethababu9223 requested review from makafsal and devadula-nandan and removed request for a team October 15, 2024 10:24
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit d4ec579
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67187e249c391d00081961c7
😎 Deploy Preview https://deploy-preview-6218--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit d4ec579
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67187e24ed911f00085b9794
😎 Deploy Preview https://deploy-preview-6218--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sangeethababu9223 sangeethababu9223 marked this pull request as draft October 15, 2024 10:45
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (43db2b7) to head (bdae6d9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6218   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files         395      395           
  Lines       12798    12798           
  Branches     4214     4214           
=======================================
  Hits        10076    10076           
  Misses       2722     2722           
Components Coverage Δ
ibm-products ∅ <0.00%> (∅)
ibm-products-web-components ∅ <0.00%> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 19: createContext requires an argument
1 participant