Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): update notification to new token format #9582

Merged
merged 8 commits into from
Sep 2, 2021

Conversation

joshblack
Copy link
Contributor

Part of #9358

Our component token strategy currently requires teams to pass in the component tokens to the theme mixin directly in order for component tokens to work across themes. This PR updates notification so that its component tokens work in different themes and introduces a way to automatically register component tokens in the theme.

Changelog

New

  • Add support for local component tokens to themes package
  • Add support for getting a CSS Custom property for a component token

Changed

  • Update eslint config to ignore *.stories.js files for prop type warnings
  • Update storybook to use the correct background token
  • Update notification story to include playground for toast
  • Move all notification style tests into one test file
  • Update notification to new token format, automatically register tokens

Removed

Testing / Reviewing

  • Visit the notification playground story
  • Turn on lowContrast in controls
  • Switch between themes
  • Verify that the background of the notification changes and the text remains readable

@joshblack joshblack requested a review from a team as a code owner September 1, 2021 16:05
@netlify
Copy link

netlify bot commented Sep 1, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 6d925f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6130b1ad30c227000827e33f

😎 Browse the preview: https://deploy-preview-9582--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 1, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 6d925f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6130b1ad2a0aec0007203a5f

😎 Browse the preview: https://deploy-preview-9582--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 1, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 6d925f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6130b1ad0408830007f1e51a

😎 Browse the preview: https://deploy-preview-9582--carbon-components-react.netlify.app

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The toast notification playground story looks great 🎉

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🎉

@kodiakhq kodiakhq bot merged commit 4d424f0 into carbon-design-system:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants