Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): add skeleton sass modules and stories #9423

Merged
merged 9 commits into from
Aug 19, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Aug 5, 2021

Closes #9130

New

  • adds skeleton styles to sass modules
  • adds SkeletonPlaceholder and SkeletonText to @carbon/react stories

Testing / Reviewing

  • ensure all test pass
  • look at the carbon-next deploy preview and go to Skeleton stories, verify that styles are rendering correctly (can cross reference current storybook styles)

@jnm2377 jnm2377 requested a review from a team as a code owner August 5, 2021 01:06
@netlify
Copy link

netlify bot commented Aug 5, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 356d4b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/611eb84e94487b00075a44b6

😎 Browse the preview: https://deploy-preview-9423--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 5, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 356d4b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/611eb84e73b11400089e9223

😎 Browse the preview: https://deploy-preview-9423--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 5, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 356d4b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/611eb84ea96cb70007878aa8

😎 Browse the preview: https://deploy-preview-9423--carbon-components-react.netlify.app

@sstrubberg
Copy link
Member

image

Getting a fail on the skeleton test.

@jnm2377
Copy link
Contributor Author

jnm2377 commented Aug 18, 2021

@tay1orjones looks like the percy snapshot for CodeSnippet is failing bc in the snapshot it's missing the show more button. I checked out the story and it's there, it just took a second to load. I'm not touching any codesnippet styles here. Any thoughts on what I should do?

@tay1orjones
Copy link
Member

@jnm2377 interesting! My first thought is to modify the codesnippet vrt and make sure cy.findByText('show more').should('be.visible') before the cypress snapshot is taken

@jnm2377
Copy link
Contributor Author

jnm2377 commented Aug 18, 2021

@tw15egan @sstrubberg sorry for the delay, this is ready for re-review now.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 9a1c110 into carbon-design-system:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton sass module refactor
4 participants